Conversation
hf-kklein
commented
Mar 14, 2023
| ebd_table = converter.convert_docx_tables_to_ebd_table() | ||
| ebd_graph = convert_table_to_graph(ebd_table) | ||
| except Exception as error: # pylint:disable=broad-except | ||
| click.secho(f"Error while converting {ebd_key}: {str(error)}; Skip!", fg="red") |
Contributor
Author
There was a problem hiding this comment.
pokemon exception by design
hf-kklein
commented
Mar 14, 2023
lord-haffi
reviewed
Mar 14, 2023
Contributor
lord-haffi
left a comment
lord-haffi
left a comment
There was a problem hiding this comment.
Imo macht es viel mehr Sinn, die dot Dateien zu speichern, wenn du mit dot auch die svgs erzeugen willst. Daher hier ein paar suggestions, damit auch dot-Dateien gespeichert werden können.
hf-kklein
commented
Mar 15, 2023
Co-authored-by: Leon Haffmans <49658102+lord-haffi@users.noreply.github.com>
lord-haffi
approved these changes
Mar 15, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See Hochfrequenz/machine-readable_entscheidungsbaumdiagramme#1 for the result