Conversation
hf-kklein
commented
Mar 16, 2023
Comment on lines
+150
to
+158
| case "berschrift1": | ||
| chapter = next(chapter_counter) | ||
| section_counter = itertools.count(start=1) | ||
| subsection_counter = itertools.count(start=1) | ||
| case "berschrift2": | ||
| section = next(section_counter) | ||
| subsection_counter = itertools.count(start=1) | ||
| case "berschrift3": | ||
| subsection = next(subsection_counter) |
Contributor
Author
There was a problem hiding this comment.
check the tests: the german "ü" is actually discarded
hf-kklein
commented
Mar 16, 2023
Comment on lines
+41
to
+46
| ("Kündigung Stromliefervertrag prüfen", EbdChapterInformation(chapter=6, section=1, subsection=1)), | ||
| ("MaBiS-ZP Aktivierung prüfen", EbdChapterInformation(chapter=7, section=2, subsection=1)), | ||
| ( | ||
| "Datenstatus nach Eingang einer AAÜZ vergeben", | ||
| EbdChapterInformation(chapter=7, section=61, subsection=2), | ||
| ), |
Contributor
Author
There was a problem hiding this comment.
diese drei einträge einfach mit der docx aus den unittests vergleichen
hf-krechan
approved these changes
Mar 16, 2023
hf-krechan
left a comment
hf-krechan
left a comment
There was a problem hiding this comment.
Habe nur eine kleine Frage.
Sonst passt es für mich
| all_ebd_keys = get_all_ebd_keys(input_path) | ||
| for ebd_key in all_ebd_keys: | ||
| click.secho(f"Processing EBD '{ebd_key}'") | ||
| for ebd_key, (ebd_title, ebd_kapitel) in all_ebd_keys.items(): |
There was a problem hiding this comment.
Braucht es die Klammern um ebd_title, ebd_kapitel ?
Contributor
Author
There was a problem hiding this comment.
sonst hätte pycharm oder black sie entfernt. ich denke s liegt daran, dass ein item aus dem dctionary ein Tuple[Key, Value] ist und Value seinerseits ein Tuple[titel, kapitel].
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.