metanorma 1.12.8 (new formula) #225342

alex-sc · 2025-05-31T21:13:05Z

This PR add a bottle for metanorma, specifically the metanorma-cli gem. More context here

Have you followed the guidelines for contributing?
Have you ensured that your commits follow the commit style guide?
Have you checked that there aren't other open pull requests for the same formula update/change?
Have you built your formula locally with HOMEBREW_NO_INSTALL_FROM_API=1 brew install --build-from-source <formula>, where <formula> is the name of the formula you're submitting?
Is your test running fine brew test <formula>, where <formula> is the name of the formula you're submitting?
Does your build pass brew audit --strict <formula> (after doing HOMEBREW_NO_INSTALL_FROM_API=1 brew install --build-from-source <formula>)? If this is a new formula, does it pass brew audit --new <formula>?

alex-sc · 2025-06-01T14:26:33Z

I'll try to fix the Linux issue tomorrow

alex-sc · 2025-06-03T19:03:34Z

Seems to be fixed

Formula/m/metanorma.rb

SMillerDev · 2025-06-04T07:58:25Z

Formula/m/metanorma.rb

+    # Install sqlite3 with brew's libsqlite3
+    system "gem", "install", "sqlite3", "-v", "1.7.3", "--no-document",
+           "--platform=ruby",
+           "--",
+           "--enable-system-libraries",
+           "--with-sqlite3-include=#{Formula["sqlite"].opt_include}",
+           "--with-sqlite3-lib=#{Formula["sqlite"].opt_lib}"
+
+    # Install pngcheck with brew's zlib (libz.so.1)
+    ENV.append "CFLAGS", "-I$(brew --prefix zlib)/include"
+    ENV.append "LDFLAGS", "-L$(brew --prefix zlib)/lib -Wl,-rpath,$(brew --prefix zlib)/lib"
+    ENV.append "PKG_CONFIG_PATH", "$(brew --prefix zlib)/lib/pkgconfig"


This would require a real zlib dependency since there is currently no dependency on brewed zlib for macos

@SMillerDev

Thanks! Before these changes the Linux build was failing with the below errors, so I've switched to the brew libsqlite3 and (as I thought) brew libz. What would you suggest on libz?

linkage --test metanorma

Unwanted system libraries: /lib/x86_64-linux-gnu/libz.so.1

brew linkage --reverse metanorma

/lib/x86_64-linux-gnu/libz.so.1 libexec/gems/pngcheck-0.3.1-x86_64-linux/lib/pngcheck/pngcheck.so libexec/gems/sqlite3-1.7.3-x86_64-linux/lib/sqlite3/3.0/sqlite3_native.so libexec/gems/sqlite3-1.7.3-x86_64-linux/lib/sqlite3/3.1/sqlite3_native.so libexec/gems/sqlite3-1.7.3-x86_64-linux/lib/sqlite3/3.2/sqlite3_native.so libexec/gems/sqlite3-1.7.3-x86_64-linux/lib/sqlite3/3.3/sqlite3_native.so

The fix seems correct for linux, but only for linux.

SMillerDev · 2025-06-04T07:59:52Z

Formula/m/metanorma.rb

+      libexec/"bin",
+      PATH:      [libexec/"bin", "$PATH"].join(":"),
+      GEM_HOME:  ENV["GEM_HOME"],
+      JAVA_HOME: Language::Java.java_home("1.8+"),


I think overridable java_home is a better choice here

alex-sc · 2025-06-04T17:37:00Z

@SMillerDev I think I've address the issues. Please review again when you have a chance. Thanks!

SMillerDev · 2025-06-04T17:45:26Z

Formula/m/metanorma.rb

+      # Install sqlite3 with brew's libsqlite3
+      system "gem", "install", "sqlite3", "-v", "1.7.3", "--no-document",
+             "--platform=ruby",
+             "--",
+             "--enable-system-libraries",
+             "--with-sqlite3-include=#{Formula["sqlite"].opt_include}",
+             "--with-sqlite3-lib=#{Formula["sqlite"].opt_lib}"
+
+      # Install pngcheck with brew's zlib (libz.so.1)
+      ENV.append "CFLAGS", "-I$(brew --prefix zlib)/include"
+      ENV.append "LDFLAGS", "-L$(brew --prefix zlib)/lib -Wl,-rpath,$(brew --prefix zlib)/lib"
+      ENV.append "PKG_CONFIG_PATH", "$(brew --prefix zlib)/lib/pkgconfig"
+      system "gem", "install", "pngcheck", "--no-document", "--platform=ruby"


Are these not needed on macOS? And does this mean they are downloaded on the fly?

sqlite3 and pngcheck are installed by the main gem by default. These are overrides to deal with the Linux libraries

And does this mean they are downloaded on the fly?

Yes. I guess that's an issue?

Should we list all the 200+ gems explicitly instead? I'm not sure if that's feasible/doable

We do have a binary distributions, but that is not going to work in homebrew-core (https://github.com/metanorma/homebrew-metanorma/blob/main/Formula/metanorma.rb)

Yeah, either it should use resources for the gems, or use a lock file to ensure that it only downloads gems we know of.

@SMillerDev Thanks. I look into it

@MikeMcQuaid The bundle install approach didn't work for some reason, so I came up with a different solution using gem install

I agree bundle install is better and clearer. Let me revisit...

@MikeMcQuaid

I've reworked the formula to use Gemlock. Since the Gemlock is not part of the tarball, I've added it to the releases as a separate artifact for now. I'll talk to the maintainers if it's possible to adjust the tarball in future releases

Now it's failing with GitHub repository not notable enough (<30 forks, <30 watchers and <75 stars) which is undestandable since the metanorma-cli in not the main repo. https://github.com/metanorma/metanorma is

@alex-sc We'd need to use the upstream Gemfile and have upstream accept a PR to add a Gemfile.lock in there before we could accept this, sorry. We don't need it in a stable release as can be applied as a patch using an upstream merged commit.

@MikeMcQuaid Sure, I understand. I suppose it makes sense to close this PR for now

@alex-sc I'm happy waiting a bit if you are! Making it draft for now instead.

SMillerDev · 2025-06-04T17:47:08Z

Formula/m/metanorma.rb

+      libexec/"bin",
+      PATH:      [libexec/"bin", "$PATH"].join(":"),
+      GEM_HOME:  ENV["GEM_HOME"],
+      JAVA_HOME: ENV["JAVA_HOME"] || Language::Java.java_home("1.8+"),


You should use the overridable Java home method for this because the current way won't work with CI

@SMillerDev You mean this, right?

JAVA_HOME: Language::Java.overridable_java_home_env,

alex-sc · 2025-06-09T06:08:05Z

Yeah, either it should use resources for the gems, or use a lock file to ensure that it only downloads gems we know of.

@SMillerDev

I've refactored the code to use vendored-gems.tar.gz and install all the required gems 'offline'. Please have a look

Co-Authored-By: Sean Molenaar <[email protected]>

github-actions bot added new formula PR adds a new formula to Homebrew/homebrew-core java Java use is a significant feature of the PR or issue ruby Ruby use is a significant feature of the PR or issue labels May 31, 2025

alex-sc force-pushed the master branch 11 times, most recently from 5069a1a to 01960d6 Compare June 1, 2025 09:33

alex-sc force-pushed the master branch 2 times, most recently from 5c8dfc3 to bb80ad9 Compare June 3, 2025 04:48

SMillerDev reviewed Jun 4, 2025

View reviewed changes

github-actions bot added the autosquash Automatically squash pull request commits according to Homebrew style. label Jun 4, 2025

alex-sc force-pushed the master branch from b59c301 to 74475b9 Compare June 4, 2025 16:49

github-actions bot removed the autosquash Automatically squash pull request commits according to Homebrew style. label Jun 4, 2025

SMillerDev reviewed Jun 4, 2025

View reviewed changes

alex-sc force-pushed the master branch 2 times, most recently from 4f26209 to d55a001 Compare June 4, 2025 19:28

alex-sc mentioned this pull request Jun 5, 2025

Homebrew Bottle for Metanorma and official formula metanorma/homebrew-metanorma#98

Open

alex-sc force-pushed the master branch 3 times, most recently from d5c6b47 to 32ca451 Compare June 9, 2025 05:06

alex-sc force-pushed the master branch 7 times, most recently from 1cc20f9 to dae7e40 Compare June 11, 2025 06:17

metanorma 1.12.8 (new formula)

0c6c06d

Co-Authored-By: Sean Molenaar <[email protected]>

alex-sc force-pushed the master branch from dae7e40 to 0c6c06d Compare June 11, 2025 06:22

MikeMcQuaid marked this pull request as draft June 12, 2025 12:39

Uh oh!

metanorma 1.12.8 (new formula) #225342

Are you sure you want to change the base?

metanorma 1.12.8 (new formula) #225342

Uh oh!

Conversation

alex-sc commented May 31, 2025

Uh oh!

alex-sc commented Jun 1, 2025

Uh oh!

alex-sc commented Jun 3, 2025

Uh oh!

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

alex-sc commented Jun 4, 2025

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

alex-sc commented Jun 9, 2025

Uh oh!

Uh oh!