Replace docker-completion with docker completion#231793
Replace docker-completion with docker completion#231793halilim wants to merge 1 commit intoHomebrew:mainfrom
Conversation
https://github.com/felixr/docker-zsh-completion was archived long time ago, while https://github.com/docker/cli/commits/master/contrib/completion/zsh/_docker is still maintained? (what is the issue to be addressed in here?) |
|
@chenrui333 interesting, I assumed it's not maintained since it's missing some features compared to |
can you file an upstream issue for it? maybe we can go from there. |
|
This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. |
The formula docker-completion uses docker/cli/contrib/completion/zsh/_docker, which is based on felixr/docker-zsh-completion, which is deprecated and archived. Docker can now generate completions with the
completioncommand.HOMEBREW_NO_INSTALL_FROM_API=1 brew install --build-from-source <formula>, where<formula>is the name of the formula you're submitting?brew test <formula>, where<formula>is the name of the formula you're submitting?brew audit --strict <formula>(after doingHOMEBREW_NO_INSTALL_FROM_API=1 brew install --build-from-source <formula>)? If this is a new formula, does it passbrew audit --new <formula>?