Skip to content

Replace docker-completion with docker completion#231793

Closed
halilim wants to merge 1 commit intoHomebrew:mainfrom
halilim:docker-completion
Closed

Replace docker-completion with docker completion#231793
halilim wants to merge 1 commit intoHomebrew:mainfrom
halilim:docker-completion

Conversation

@halilim
Copy link
Copy Markdown
Contributor

@halilim halilim commented Jul 30, 2025

The formula docker-completion uses docker/cli/contrib/completion/zsh/_docker, which is based on felixr/docker-zsh-completion, which is deprecated and archived. Docker can now generate completions with the completion command.


  • Have you followed the guidelines for contributing?
  • Have you ensured that your commits follow the commit style guide?
  • Have you checked that there aren't other open pull requests for the same formula update/change?
  • Have you built your formula locally with HOMEBREW_NO_INSTALL_FROM_API=1 brew install --build-from-source <formula>, where <formula> is the name of the formula you're submitting?
  • Is your test running fine brew test <formula>, where <formula> is the name of the formula you're submitting?
  • Does your build pass brew audit --strict <formula> (after doing HOMEBREW_NO_INSTALL_FROM_API=1 brew install --build-from-source <formula>)? If this is a new formula, does it pass brew audit --new <formula>?

@github-actions github-actions bot added autosquash Automatically squash pull request commits according to Homebrew style. go Go use is a significant feature of the PR or issue labels Jul 30, 2025
@halilim halilim marked this pull request as ready for review July 30, 2025 22:23
@chenrui333
Copy link
Copy Markdown
Member

@halilim
Copy link
Copy Markdown
Contributor Author

halilim commented Jul 30, 2025

@chenrui333 interesting, I assumed it's not maintained since it's missing some features compared to docker completion zsh --help, sorry. E.g., docker compose <tab> brings up nothing, while the new one lists compose subcommands.

@chenrui333
Copy link
Copy Markdown
Member

@chenrui333 interesting, I assumed it's not maintained since it's missing some features compared to docker completion zsh --help, sorry. E.g., docker compose <tab> brings up nothing, while the new one lists compose subcommands.

can you file an upstream issue for it? maybe we can go from there.

@chenrui333 chenrui333 added the upstream issue An upstream issue report is needed label Jul 31, 2025
@chenrui333 chenrui333 marked this pull request as draft July 31, 2025 13:16
@github-actions
Copy link
Copy Markdown
Contributor

This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs.

@github-actions github-actions bot added the stale No recent activity label Aug 22, 2025
@github-actions github-actions bot closed this Aug 29, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

autosquash Automatically squash pull request commits according to Homebrew style. go Go use is a significant feature of the PR or issue stale No recent activity upstream issue An upstream issue report is needed

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants