Skip to content

node: unbundle simdutf#277447

Open
carlocab wants to merge 1 commit intomainfrom
node-unbundle-simdutf
Open

node: unbundle simdutf#277447
carlocab wants to merge 1 commit intomainfrom
node-unbundle-simdutf

Conversation

@carlocab
Copy link
Copy Markdown
Member

  • Have you followed the guidelines for contributing?
  • Have you ensured that your commits follow the commit style guide?
  • Have you checked that there aren't other open pull requests for the same formula update/change?
  • Have you built your formula locally with HOMEBREW_NO_INSTALL_FROM_API=1 brew install --build-from-source <formula>?
  • Is your test running fine brew test <formula>?
  • Does your build pass brew audit --strict <formula> (after doing HOMEBREW_NO_INSTALL_FROM_API=1 brew install --build-from-source <formula>)? If this is a new formula, does it pass brew audit --new <formula>?

  • AI was used to generate or assist with generating this PR. Please specify below how you used AI to help you, and what steps you have taken to manually verify the changes.

We unbundled merve in 90df578. merve
depends on simdutf, and we don't want to load two different versions
of simdutf in-process. This means we should try to unbundle simdutf
too.

We unbundled merve in 90df578. merve
depends on `simdutf`, and we don't want to load two different versions
of `simdutf` in-process. This means we should try to unbundle `simdutf`
too.
@github-actions github-actions Bot added long build Set a long timeout for formula testing icu4c ICU use is a significant feature of the PR or issue long dependent tests Set a long timeout for dependent testing labels Apr 14, 2026
@cho-m
Copy link
Copy Markdown
Member

cho-m commented Apr 14, 2026

The sub-directory part will need some extra logic to allow skipping a directory, maybe via nil input.

Also, there is another simdutf that cannot be unbundled included in V8.

I think default build would use the copy in V8 in all locations (V8, node and merve).


It would be simpler to disable simdutf in merve but there is a performance cost.

Though, we haven't enabled simdutf in ada-url while it is enabled upstream so whatever we do should match for merve and ada-url:

@GunniBusch
Copy link
Copy Markdown
Contributor

GunniBusch commented Apr 14, 2026

The sub-directory part will need some extra logic to allow skipping a directory, maybe via nil input.

Also, there is another simdutf that cannot be unbundled included in V8.

I think default build would use the copy in V8 in all locations (V8, node and merve).

It would be simpler to disable simdutf in merve but there is a performance cost.

Though, we haven't enabled simdutf in ada-url while it is enabled upstream so whatever we do should match for merve and ada-url:

also i think there is already a pr that proposed a shared v8, corresponding to the issue nodejs/node#53509, but was closed because the branch was deleted.
nodejs/node#62097

But I am currently experimenting with these changes and try to maybe open another pr upstream and here to add support for devendoring v8. (I think they want proof that it works hence a pr here)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

icu4c ICU use is a significant feature of the PR or issue long build Set a long timeout for formula testing long dependent tests Set a long timeout for dependent testing

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants