Skip to content

Allow client extra headers #30

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Jan 17, 2022

Conversation

fabiolab
Copy link
Contributor

This pull request aims to make extra headers possible for http requests.
Indeed, deploying LabelStudio may require specific headers as Proxy-Authorization.

Current implementation adds a dict parameter in the client constructor. This may includes extra keys that will be added to the "basic" header {'Authorization': f'Token {self.api_key}'}

Run the unit test with make :

make test

@fabiolab
Copy link
Contributor Author

Hey !
Thanks for approving my PR (and for your job on this tool). Do you know how many times it would take to integrate it in a new version of your SDK ?
Regards.
Fabrice

@makseq makseq merged commit 3b2cd5e into HumanSignal:master Jan 17, 2022
@makseq
Copy link
Member

makseq commented Jan 17, 2022

Hi, @fabiolab, your branch is merged, but I can't say when we release a new pypi package, think it will be soon.

@fabiolab
Copy link
Contributor Author

Great! Thanks @makseq! No problem for the release. Keep on with your great job.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants