Skip to content

chore: upgrade NumPy to 2.0 #436

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 10 commits into from
Apr 23, 2025
Merged

chore: upgrade NumPy to 2.0 #436

merged 10 commits into from
Apr 23, 2025

Conversation

benglewis
Copy link
Contributor

@benglewis benglewis commented Apr 2, 2025 •
edited
Loading

Fixes #296
Update NumPy version to 2.0.0 in the repository.

  • pyproject.toml

    • Change NumPy version from >=1.26.4,<2.0.0 to 2.0.0.

  • examples/mensuration_and_polling/requirements.txt

    • Change NumPy version from ~=1.24.3 to ~=2.0.0.

For more details, open the Copilot Workspace session.

@benglewis
Upgrade NumPy to 2.0
4626318 
Update NumPy version to 2.0.0 in the repository.

* **pyproject.toml**
  - Change NumPy version from `>=1.26.4,<2.0.0` to `2.0.0`.

* **examples/mensuration_and_polling/requirements.txt**
  - Change NumPy version from `~=1.24.3` to `~=2.0.0`.

---

For more details, open the [Copilot Workspace session](https://copilot-workspace.githubnext.com/HumanSignal/label-studio-sdk?shareId=XXXX-XXXX-XXXX-XXXX).
@benglewis benglewis changed the title Upgrade NumPy to 2.0 chore(deps): וpgrade NumPy to 2.0 Apr 2, 2025
@benglewis benglewis changed the title chore(deps): וpgrade NumPy to 2.0 chore(deps): upgrade NumPy to 2.0 Apr 2, 2025
@benglewis
Update poetry.lock file to reflect changes in dependencies and meta…
00be73f 
…data.

* **NumPy Version Update**
  - Change NumPy version from `1.26.4` to `2.0.0`
  - Update file hashes for new NumPy version

* **Metadata and Groups**
  - Update `lock-version` from `2.0` to `2.1`
  - Add `groups` attribute to various packages
  - Update `content-hash` to reflect changes

* **Dependency Updates**
  - Update versions and markers for various dependencies
  - Add or modify `groups` and `markers` attributes for several packages
@benglewis benglewis changed the title chore(deps): upgrade NumPy to 2.0 chore: upgrade NumPy to 2.0 Apr 2, 2025
@benglewis benglewis marked this pull request as ready for review April 2, 2025 11:03
@benglewis
Copy link
Contributor Author

Upgraded numpy version dependency, as per issue: #296

@benglewis benglewis mentioned this pull request Apr 8, 2025
Closed
@Fran-ATRIA
Copy link

Hi. Is there an estimated date for when will we get this on a nightly build?

@benglewis benglewis mentioned this pull request Apr 15, 2025
Closed
@pakelley
Copy link
Contributor

I relaxed the pin on this to still allow numpy 1. I know you're out the next couple days, but I'm going to go ahead and get this merged. If there's any issue with that change lmk and we can resolve it when you're back 🙂

@pakelley
Copy link
Contributor

Ugh, it looks like the POETRY_VERSION still isn't being set on this PR (though I do see it properly installing poetry on your PR to your own master branch...)
Mind taking a look at your variables again when you're back in? As soon as we get CI passing this can be (finally) merged in 🙂
Thank you for your contribution!!

@benglewis
Copy link
Contributor Author

@pakelley Unfortunately I don't think that there is anything that I can do about this since it looks like it is a GitHub Actions restriction:
https://github.com/orgs/community/discussions/44322
I guess that you could just maybe add a fallback for the variable in the GitHub Actions workflow, but clearly that isn't an ideal solution 🙊🙈

@benglewis benglewis requested a review from a team as a code owner April 21, 2025 09:18
@benglewis
Copy link
Contributor Author

@pakelley I have pulled updates from the upstream main and updated the poetry.lock file and I have added a fallback value for POETRY_VERSION to the PyTest tests. This should mean that this PR should pass this time around 🙏 I think that you just need to re-approve for the tests to re-run

@nikitabelonogov
Merge remote-tracking branch 'origin/master' into upgrade-numpy
9ee70dc 
# Conflicts:
#	.github/workflows/tests.yml
@nikitabelonogov
Copy link
Member

nikitabelonogov commented Apr 21, 2025 •
edited
Loading

Hi @benglewis We decided to take a slightly different approach for the poetry version 68d512f

merged to your branch

@benglewis
Copy link
Contributor Author

@nikitabelonogov Great. Can we merge this now then? 🙊

@farioas
Copy link
Member

farioas commented Apr 21, 2025

@benglewis Sorry for the confusion, we are only here to fix the build problem.

@pakelley This change will be overridden by fern on the next run by:
https://github.com/HumanSignal/label-studio-client-generator/blob/a59e801858ae432d4b2c164629a32b1cae30d0e6/fern/generators.yml#L49

@pakelley
Copy link
Contributor

Ah, I see, I'll update that in the client generator, thanks @farioas

@pakelley
Copy link
Contributor

client generator PR here, look good to you @farioas and @nikitabelonogov ?

@pakelley pakelley merged commit 123f793 into HumanSignal:master Apr 23, 2025
4 checks passed
@pakelley
Copy link
Contributor

I know this will be made redundant by the client generator PR, but merging it in anyway

@benglewis benglewis deleted the upgrade-numpy branch April 27, 2025 09:08
@micaelakaplan
Copy link

Hi @benglewis ! Could you email me regarding this PR? [email protected] thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pakelley pakelley pakelley approved these changes

Assignees
No one assigned
Labels
chore
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Numpy version dependency
6 participants
@benglewis @Fran-ATRIA @pakelley @nikitabelonogov @farioas @micaelakaplan