Skip to content

fix: DEV-2236: Stored XSS via SVG file #2273

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 13 commits into from
Jul 25, 2022
Merged

fix: DEV-2236: Stored XSS via SVG file #2273

merged 13 commits into from
Jul 25, 2022

Conversation

dvwright
Copy link
Contributor

@dvwright dvwright commented Apr 26, 2022

  • strip harmful tags from SVG files

@dvwright dvwright self-assigned this Apr 26, 2022
@dvwright dvwright requested a review from makseq April 26, 2022 18:13
@codecov
Copy link

codecov bot commented Apr 26, 2022

Codecov Report

Merging #2273 (af45e0c) into develop (17b40da) will decrease coverage by 0.33%.
The diff coverage is n/a.

❗ Current head af45e0c differs from pull request most recent head 03d569b. Consider uploading reports for the commit 03d569b to get more accurate results

@@             Coverage Diff             @@
##           develop    #2273      +/-   ##
===========================================
- Coverage    77.80%   77.46%   -0.34%     
===========================================
  Files          137      139       +2     
  Lines         9951    10175     +224     
===========================================
+ Hits          7742     7882     +140     
- Misses        2209     2293      +84     
Impacted Files Coverage Δ
label_studio/label_studio/users/mixins.py 75.00% <0.00%> (-12.50%) ⬇️
...bel_studio/label_studio/organizations/functions.py 66.66% <0.00%> (-10.26%) ⬇️
label_studio/label_studio/data_manager/managers.py 78.34% <0.00%> (-3.36%) ⬇️
label_studio/label_studio/users/forms.py 87.09% <0.00%> (-2.38%) ⬇️
label_studio/label_studio/tasks/serializers.py 84.27% <0.00%> (-2.27%) ⬇️
label_studio/label_studio/data_manager/api.py 83.75% <0.00%> (-1.97%) ⬇️
...abel_studio/label_studio/data_manager/functions.py 64.70% <0.00%> (-1.97%) ⬇️
.../label_studio/data_manager/actions/experimental.py 18.26% <0.00%> (-1.25%) ⬇️
..._studio/label_studio/data_manager/actions/basic.py 75.40% <0.00%> (-0.87%) ⬇️
label_studio/label_studio/tasks/models.py 89.20% <0.00%> (-0.85%) ⬇️
... and 25 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 013e681...03d569b. Read the comment docs.

@dvwright dvwright marked this pull request as draft May 6, 2022 00:07
@dvwright
Copy link
Contributor Author

dvwright commented May 6, 2022

needs more testing, does work for the example provided by the user

@dvwright dvwright marked this pull request as ready for review May 6, 2022 00:24
@dvwright dvwright requested a review from makseq May 6, 2022 20:28
@dvwright dvwright requested a review from makseq May 9, 2022 21:55
@dvwright dvwright requested a review from makseq May 10, 2022 21:42
@dvwright dvwright requested a review from makseq May 11, 2022 19:24
@dvwright dvwright marked this pull request as draft May 20, 2022 20:43
@dvwright dvwright marked this pull request as ready for review May 20, 2022 22:54
@github-actions github-actions bot added the fix label Jul 25, 2022
@makseq makseq enabled auto-merge (squash) July 25, 2022 13:05
@makseq makseq merged commit 53f6308 into develop Jul 25, 2022
@makseq makseq deleted the dev-2236 branch July 25, 2022 13:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants