Skip to content

fix: DEV-2367: User is able to edit Time Series results imported as read-only #2444

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jun 10, 2022

Conversation

yyassi-heartex
Copy link
Contributor

resolving a readonly region issue where it was still possible to edit the region. removed handles when RO

# Conflicts:
#	label_studio/frontend/dist/lsf/js/main.js
#	label_studio/frontend/dist/lsf/js/main.js.map
#	label_studio/frontend/dist/lsf/version.json
@codecov
Copy link

codecov bot commented Jun 10, 2022

Codecov Report

Merging #2444 (4135937) into develop (17b40da) will decrease coverage by 0.39%.
The diff coverage is n/a.

@@             Coverage Diff             @@
##           develop    #2444      +/-   ##
===========================================
- Coverage    77.80%   77.40%   -0.40%     
===========================================
  Files          137      141       +4     
  Lines         9951    10242     +291     
===========================================
+ Hits          7742     7928     +186     
- Misses        2209     2314     +105     
Impacted Files Coverage Δ
label_studio/label_studio/users/mixins.py 75.00% <0.00%> (-12.50%) ⬇️
...bel_studio/label_studio/organizations/functions.py 66.66% <0.00%> (-10.26%) ⬇️
label_studio/label_studio/users/forms.py 87.09% <0.00%> (-2.38%) ⬇️
label_studio/label_studio/tasks/serializers.py 84.27% <0.00%> (-2.27%) ⬇️
label_studio/label_studio/tasks/models.py 87.85% <0.00%> (-2.20%) ⬇️
...abel_studio/label_studio/data_manager/functions.py 64.70% <0.00%> (-1.97%) ⬇️
label_studio/label_studio/core/label_config.py 71.54% <0.00%> (-1.85%) ⬇️
label_studio/label_studio/data_manager/managers.py 80.17% <0.00%> (-1.54%) ⬇️
.../label_studio/data_manager/actions/experimental.py 18.62% <0.00%> (-0.89%) ⬇️
label_studio/label_studio/core/redis.py 43.33% <0.00%> (-0.74%) ⬇️
... and 32 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 63b0010...4135937. Read the comment docs.

@Gondragos Gondragos merged commit 3f4ace8 into develop Jun 10, 2022
@Gondragos Gondragos deleted the fb-dev-2367 branch June 10, 2022 02:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants