Skip to content

fix: DEV-2647: rotating bounding box bugs #2535

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 7 commits into from
Jun 23, 2022
Merged

Conversation

yyassi-heartex
Copy link
Contributor

this'll resolve an issue where unselecting a rectangle will deselect the rectangle tool altogether, giving the impression that the tool is no longer responsive.

2 point rectangle and 3 point rectangle can now both be used if the FF is set to true

@codecov
Copy link

codecov bot commented Jun 17, 2022

Codecov Report

Merging #2535 (f20ef12) into develop (17b40da) will decrease coverage by 0.28%.
The diff coverage is n/a.

@@             Coverage Diff             @@
##           develop    #2535      +/-   ##
===========================================
- Coverage    77.80%   77.51%   -0.29%     
===========================================
  Files          137      141       +4     
  Lines         9951    10296     +345     
===========================================
+ Hits          7742     7981     +239     
- Misses        2209     2315     +106     
Impacted Files Coverage Δ
label_studio/label_studio/users/mixins.py 75.00% <0.00%> (-12.50%) ⬇️
...bel_studio/label_studio/organizations/functions.py 66.66% <0.00%> (-10.26%) ⬇️
...l_studio/label_studio/core/templatetags/filters.py 48.75% <0.00%> (-6.20%) ⬇️
label_studio/label_studio/users/api.py 80.45% <0.00%> (-3.88%) ⬇️
label_studio/label_studio/ml/serializers.py 92.30% <0.00%> (-2.43%) ⬇️
label_studio/label_studio/core/utils/contextlog.py 44.55% <0.00%> (-2.33%) ⬇️
label_studio/label_studio/tasks/serializers.py 84.27% <0.00%> (-2.27%) ⬇️
label_studio/label_studio/tasks/models.py 87.85% <0.00%> (-2.20%) ⬇️
...abel_studio/label_studio/data_manager/functions.py 64.70% <0.00%> (-1.97%) ⬇️
label_studio/label_studio/core/label_config.py 71.54% <0.00%> (-1.85%) ⬇️
... and 50 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8b6bb63...f20ef12. Read the comment docs.

@yyassi-heartex yyassi-heartex merged commit 212ae24 into develop Jun 23, 2022
@hlomzik hlomzik deleted the fb-dev-2647 branch June 23, 2022 13:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants