Skip to content

fix: DEV-1947: Fixed tabs randomly mixed after label stream #2892

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Sep 2, 2022

Conversation

guilhermemachado26
Copy link
Contributor

Description of the proposed changes

Tabs are being randomly mixed after label stream. It's not guaranteed that backend will always return in the expected order.

These changes add an ASC ID ordering in the view class to avoid this issue.

Jira Ticket

https://heartex.atlassian.net/browse/DEV-1947

@guilhermemachado26 guilhermemachado26 self-assigned this Sep 1, 2022
@swarmia
Copy link

swarmia bot commented Sep 1, 2022

@github-actions github-actions bot added the fix label Sep 1, 2022
@codecov
Copy link

codecov bot commented Sep 1, 2022

Codecov Report

Base: 77.80% // Head: 77.11% // Decreases project coverage by -0.68% ⚠️

Coverage data is based on head (dbdf998) compared to base (17b40da).
Patch has no changes to coverable lines.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #2892      +/-   ##
===========================================
- Coverage    77.80%   77.11%   -0.69%     
===========================================
  Files          137      146       +9     
  Lines         9951    10691     +740     
===========================================
+ Hits          7742     8244     +502     
- Misses        2209     2447     +238     
Impacted Files Coverage Δ
label_studio/label_studio/users/mixins.py 75.00% <0.00%> (-12.50%) ⬇️
...bel_studio/label_studio/organizations/functions.py 66.66% <0.00%> (-10.26%) ⬇️
label_studio/label_studio/organizations/api.py 78.09% <0.00%> (-6.28%) ⬇️
...l_studio/label_studio/core/templatetags/filters.py 48.75% <0.00%> (-6.20%) ⬇️
..._studio/label_studio/core/settings/label_studio.py 94.28% <0.00%> (-5.72%) ⬇️
.../label_studio/data_manager/actions/experimental.py 14.79% <0.00%> (-4.72%) ⬇️
label_studio/label_studio/tasks/api.py 88.26% <0.00%> (-4.43%) ⬇️
label_studio/label_studio/ml/api.py 86.17% <0.00%> (-4.38%) ⬇️
label_studio/label_studio/ml/serializers.py 92.30% <0.00%> (-2.43%) ⬇️
label_studio/label_studio/core/utils/contextlog.py 44.55% <0.00%> (-2.33%) ⬇️
... and 71 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@AndrejOros AndrejOros marked this pull request as draft September 2, 2022 14:03
@guilhermemachado26 guilhermemachado26 marked this pull request as ready for review September 2, 2022 19:05
@guilhermemachado26 guilhermemachado26 merged commit a9e0163 into develop Sep 2, 2022
@github-actions github-actions bot deleted the fb-dev-1947 branch September 2, 2022 21:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants