feat: LSDV-3958: Server side encryption for Target Storage (AES256) #4180
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for label-studio-docs-new-theme ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
✅ Deploy Preview for heartex-docs ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
added 2 commits
May 12, 2023 08:30
makseq
reviewed
May 12, 2023
| s3.Object(self.bucket, key).put(Body=json.dumps(ser_annotation)) | ||
| additional_params = {} | ||
| if flag_set('fflag_feat_back_lsdv_3958_server_side_encryption_for_target_storage_short', user=annotation.completed_by): | ||
| additional_params = {'ServerSideEncryption': 'AES256'} |
There was a problem hiding this comment.
should it be enabled for all storages now?
There was a problem hiding this comment.
I think so, since it's enabled by default in S3
|
/git merge develop
|
Codecov ReportPatch coverage has no change and project coverage change:
Additional details and impacted files@@ Coverage Diff @@
## develop #4180 +/- ##
===========================================
+ Coverage 76.05% 76.06% +0.01%
===========================================
Files 156 156
Lines 11888 11893 +5
===========================================
+ Hits 9041 9046 +5
Misses 2847 2847 ☔ View full report in Codecov by Sentry. |
makseq
requested changes
May 13, 2023
makseq
approved these changes
May 14, 2023
shayantabatabaee
pushed a commit
to shayantabatabaee/label-studio
that referenced
this pull request
Sep 19, 2023
…umanSignal#4180) * Add AES256 SSE encryption to S3 * Add feature flag * Fix test fixture * Address comments --------- Co-authored-by: nik <[email protected]> Co-authored-by: niklub <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR fulfills these requirements
[fix|feat|ci|chore|doc]: TICKET-ID: Short description of change madeex.fix: DEV-XXXX: Removed inconsistent code usage causing intermittent errorsChange has impacts in these area(s)
(check all that apply)
Describe the reason for change
(link to issue, supportive screenshots etc.)
What does this fix?
(if this is a bug fix)
What is the new behavior?
(if this is a breaking or feature change)
What is the current behavior?
(if this is a breaking or feature change)
What libraries were added/updated?
(list all with version changes)
Does this change affect performance?
(if so describe the impacts positive or negative)
Does this change affect security?
(if so describe the impacts positive or negative)
What alternative approaches were there?
(briefly list any if applicable)
What feature flags were used to cover this change?
(briefly list any if applicable)
Does this PR introduce a breaking change?
(check only one)
What level of testing was included in the change?
(check all that apply)
Which logical domain(s) does this change affect?
(for bug fixes/features, be as precise as possible. ex. Authentication, Annotation History, Review Stream etc.)