fix: OPTIC-883: Export data modal footer not visible when scrollable #6085
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for heartex-docs canceled.
|
✅ Deploy Preview for label-studio-docs-new-theme canceled.
|
yyassi-heartex
approved these changes
Jul 11, 2024
hlomzik
approved these changes
Jul 11, 2024
@yyassi-heartex it's a popular workaround with outer paddings you can't control. it would be better without it with better layout for sure, but I think they are just okay |
AndrejOros
approved these changes
Jul 12, 2024
bmartel
added a commit
that referenced
this pull request
Jul 12, 2024
…6085) App redesign had changed a couple of the overflow values on modals, which broke the ability to provide a position sticky footer. This made it difficult to present modal forms with scrolling content and have the form submit button visible at all times. _Before_  _After_ 
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
App redesign had changed a couple of the overflow values on modals, which broke the ability to provide a position sticky footer. This made it difficult to present modal forms with scrolling content and have the form submit button visible at all times.
Before
After
