Skip to content

fix: LEAP-552: Hide the comments tab on preview #6132

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jul 29, 2024
Merged

Conversation

juliosgarbi
Copy link
Contributor

@juliosgarbi juliosgarbi commented Jul 25, 2024

PR fulfills these requirements

  • Commit message(s) and PR title follows the format [fix|feat|ci|chore|doc]: TICKET-ID: Short description of change made ex. fix: DEV-XXXX: Removed inconsistent code usage causing intermittent errors
  • Tests for the changes have been added/updated (for bug fixes/features)
  • Docs have been added/updated (for bug fixes/features)
  • Best efforts were made to ensure docs/code are concise and coherent (checked for spelling/grammatical errors, commented out code, debug logs etc.)
  • Self-reviewed and ran all changes on a local instance (for bug fixes/features)

Change has impacts in these area(s)

(check all that apply)

  • Product design
  • Backend (Database)
  • Backend (API)
  • Frontend

Describe the reason for change

The comments tab should be displayed just on LSE, on LSO we should hide it

What does this fix?

We are removing the interface annotations:comments on LS initialization on LSO preview page

Screenshot 2024-07-25 at 14 19 52

Copy link

netlify bot commented Jul 25, 2024

Deploy Preview for heartex-docs canceled.

Name Link
🔨 Latest commit da731fa
🔍 Latest deploy log https://app.netlify.com/sites/heartex-docs/deploys/66a4fa759bd27700085be564

@github-actions github-actions bot added the fix label Jul 25, 2024
Copy link

netlify bot commented Jul 25, 2024

Deploy Preview for label-studio-docs-new-theme canceled.

Name Link
🔨 Latest commit da731fa
🔍 Latest deploy log https://app.netlify.com/sites/label-studio-docs-new-theme/deploys/66a4fa7557cdf100081fc913

@juliosgarbi juliosgarbi merged commit aa07390 into develop Jul 29, 2024
31 checks passed
@juliosgarbi juliosgarbi deleted the fb-leap-552 branch July 29, 2024 13:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants