You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Commit message(s) and PR title follows the format [fix|feat|ci|chore|doc]: TICKET-ID: Short description of change made ex. fix: DEV-XXXX: Removed inconsistent code usage causing intermittent errors
Tests for the changes have been added/updated (for bug fixes/features)
Docs have been added/updated (for bug fixes/features)
Best efforts were made to ensure docs/code are concise and coherent (checked for spelling/grammatical errors, commented out code, debug logs etc.)
Self-reviewed and ran all changes on a local instance (for bug fixes/features)
Change has impacts in these area(s)
(check all that apply)
Product design
Backend (Database)
Backend (API)
Frontend
Describe the reason for change
(link to issue, supportive screenshots etc.)
No shortcut existed to hide all regions. It had to be done through a click tot he dedicated button on the sidebar
What does this fix?
(if this is a bug fix)
What is the new behavior?
(if this is a breaking or feature change)
by default, ctrl+h now hide all regions if one is visible. If none is visible, it show all regions.
What is the current behavior?
(if this is a breaking or feature change)
ctrl + h has no behavior on label studio.
What libraries were added/updated?
(list all with version changes)
None
Does this change affect performance?
(if so describe the impacts positive or negative)
No
Does this change affect security?
(if so describe the impacts positive or negative)
No
What alternative approaches were there?
(briefly list any if applicable)
Click on the sidebar button
What feature flags were used to cover this change?
(briefly list any if applicable)
None
Does this PR introduce a breaking change?
(check only one)
Yes, and covered entirely by feature flag(s)
Yes, and covered partially by feature flag(s)
No
Not sure (briefly explain the situation below)
What level of testing was included in the change?
(check all that apply)
e2e
integration
unit
Does manual testing counts for a shortcut (I kind of hate myself for asking)?
Which logical domain(s) does this change affect?
(for bug fixes/features, be as precise as possible. ex. Authentication, Annotation History, Review Stream etc.)
Oh, thank you for patience and for this contribution, @LouisJULIEN !
It's very straightforward and precise improvement, we'll run it through our process and will merge soon!
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
LouisJULIEN
force-pushed
the
hide-all-shorcut-2
branch
3 times, most recently
from
PR fulfills these requirements
[fix|feat|ci|chore|doc]: TICKET-ID: Short description of change madeex.fix: DEV-XXXX: Removed inconsistent code usage causing intermittent errorsChange has impacts in these area(s)
(check all that apply)
Describe the reason for change
(link to issue, supportive screenshots etc.)
No shortcut existed to hide all regions. It had to be done through a click tot he dedicated button on the sidebar
What does this fix?
(if this is a bug fix)
What is the new behavior?
(if this is a breaking or feature change)
by default, ctrl+h now hide all regions if one is visible. If none is visible, it show all regions.
What is the current behavior?
(if this is a breaking or feature change)
ctrl + h has no behavior on label studio.
What libraries were added/updated?
(list all with version changes)
None
Does this change affect performance?
(if so describe the impacts positive or negative)
No
Does this change affect security?
(if so describe the impacts positive or negative)
No
What alternative approaches were there?
(briefly list any if applicable)
Click on the sidebar button
What feature flags were used to cover this change?
(briefly list any if applicable)
None
Does this PR introduce a breaking change?
(check only one)
What level of testing was included in the change?
(check all that apply)
Does manual testing counts for a shortcut (I kind of hate myself for asking)?
Which logical domain(s) does this change affect?
(for bug fixes/features, be as precise as possible. ex. Authentication, Annotation History, Review Stream etc.)