Skip to content

chore: LEAP-1378: bump nltk to 3.9.1 to get off git tag version #6220

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 19, 2024

Conversation

jombooth
Copy link
Contributor

NLTK 3.9.1 fixes some performance issues with the PunktTokenizer, but more importantly, this allows us to download from pypi instead of github during image build.

@github-actions github-actions bot added the chore label Aug 19, 2024
Copy link

netlify bot commented Aug 19, 2024

Deploy Preview for label-studio-docs-new-theme canceled.

Name Link
🔨 Latest commit 8edc824
🔍 Latest deploy log https://app.netlify.com/sites/label-studio-docs-new-theme/deploys/66c37494ca1982000854f1ba

Copy link

netlify bot commented Aug 19, 2024

Deploy Preview for heartex-docs canceled.

Name Link
🔨 Latest commit 8edc824
🔍 Latest deploy log https://app.netlify.com/sites/heartex-docs/deploys/66c3749472f0b7000860526d

Copy link

codecov bot commented Aug 19, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 76.67%. Comparing base (34d8d4a) to head (8edc824).
Report is 2 commits behind head on develop.

Additional details and impacted files
@@           Coverage Diff            @@
##           develop    #6220   +/-   ##
========================================
  Coverage    76.67%   76.67%           
========================================
  Files          169      169           
  Lines        13695    13695           
========================================
  Hits         10501    10501           
  Misses        3194     3194           
Flag Coverage Δ
pytests 76.67% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

@amymrou amymrou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@jombooth jombooth merged commit df5db45 into develop Aug 19, 2024
40 checks passed
@jombooth jombooth deleted the fb-LEAP-1378/upgrade-nltk-again branch August 19, 2024 17:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants