Skip to content

fix: RND-120: Redis storage doesn't have db field and redis target misses validation_connection() #6255

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Aug 26, 2024

Conversation

makseq
Copy link
Member

@makseq makseq commented Aug 26, 2024

  1. Add Database number (db) on the Redis storage form:
    image

  2. Add simple validate_connection() for Redis target storages.

Change has impacts in these area(s)

(check all that apply)

  • Product design
  • Backend (Database)
  • Backend (API)
  • Frontend

Copy link

netlify bot commented Aug 26, 2024

Deploy Preview for label-studio-docs-new-theme canceled.

Name Link
🔨 Latest commit 37d3e0c
🔍 Latest deploy log https://app.netlify.com/sites/label-studio-docs-new-theme/deploys/66cc69f511612200081e6b2a

@github-actions github-actions bot added the fix label Aug 26, 2024
Copy link

netlify bot commented Aug 26, 2024

Deploy Preview for heartex-docs canceled.

Name Link
🔨 Latest commit 37d3e0c
🔍 Latest deploy log https://app.netlify.com/sites/heartex-docs/deploys/66cc69f52cb0d90008857a01

Copy link

codecov bot commented Aug 26, 2024

Codecov Report

Attention: Patch coverage is 25.00000% with 3 lines in your changes missing coverage. Please review.

Project coverage is 76.66%. Comparing base (9663da0) to head (37d3e0c).
Report is 1 commits behind head on develop.

Files Patch % Lines
label_studio/io_storages/redis/models.py 25.00% 3 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #6255      +/-   ##
===========================================
- Coverage    76.68%   76.66%   -0.02%     
===========================================
  Files          169      169              
  Lines        13698    13702       +4     
===========================================
+ Hits         10504    10505       +1     
- Misses        3194     3197       +3     
Flag Coverage Δ
pytests 76.66% <25.00%> (-0.02%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@makseq makseq merged commit 97c881d into develop Aug 26, 2024
38 of 40 checks passed
@makseq makseq deleted the fb-rnd-120 branch August 26, 2024 11:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants