Skip to content

fix: LEAP-1494: Padding in new textarea is missing in LSO #6496

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

ricardoantoniocm
Copy link
Contributor

@ricardoantoniocm ricardoantoniocm commented Oct 9, 2024

Ensures padding and border-radius is correct for added textarea regions and corresponding textarea fields

PR fulfills these requirements

  • Commit message(s) and PR title follows the format [fix|feat|ci|chore|doc]: TICKET-ID: Short description of change made ex. fix: DEV-XXXX: Removed inconsistent code usage causing intermittent errors
  • Tests for the changes have been added/updated (for bug fixes/features)
  • Docs have been added/updated (for bug fixes/features)
  • Best efforts were made to ensure docs/code are concise and coherent (checked for spelling/grammatical errors, commented out code, debug logs etc.)
  • Self-reviewed and ran all changes on a local instance (for bug fixes/features)

Change has impacts in these area(s)

(check all that apply)

  • Product design
  • Backend (Database)
  • Backend (API)
  • Frontend

What does this fix?

Padding and border radius missing for Textarea component and its results container.

What is the new behavior?

Textarea and results containers now have expected padding and border radius. CSS variables used now use the values for the corresponding tokens.

Screenshots:

Previous look:
image
image

Improved look:
image

image

Which logical domain(s) does this change affect?

(for bug fixes/features, be as precise as possible. ex. Authentication, Annotation History, Review Stream etc.)
Label Stream, Review Stream and Labeling Configuration

@github-actions github-actions bot added the fix label Oct 9, 2024
Copy link

netlify bot commented Oct 9, 2024

Deploy Preview for heartex-docs canceled.

Name Link
🔨 Latest commit 5fe7b2d
🔍 Latest deploy log https://app.netlify.com/sites/heartex-docs/deploys/67095f91187c4b0009ed247e

Copy link

netlify bot commented Oct 9, 2024

Deploy Preview for label-studio-docs-new-theme canceled.

Name Link
🔨 Latest commit 5fe7b2d
🔍 Latest deploy log https://app.netlify.com/sites/label-studio-docs-new-theme/deploys/67095f911ffd410008407a17

@ricardoantoniocm
Copy link
Contributor Author

ricardoantoniocm commented Oct 9, 2024

/git merge

Workflow run
Successfully merged: 37 files changed, 282 insertions(+), 88 deletions(-)

@ricardoantoniocm ricardoantoniocm merged commit 3b04299 into develop Oct 15, 2024
33 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants