-
Notifications
You must be signed in to change notification settings - Fork 2.9k
fix: LEAP-1494: Padding in new textarea is missing in LSO #6496
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
ricardoantoniocm
merged 8 commits into
develop
from
fb-leap-1494/padding-in-new-textarea-is-missing-in-lso
Oct 15, 2024
Merged
fix: LEAP-1494: Padding in new textarea is missing in LSO #6496
ricardoantoniocm
merged 8 commits into
develop
from
fb-leap-1494/padding-in-new-textarea-is-missing-in-lso
Oct 15, 2024
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for heartex-docs canceled.
|
✅ Deploy Preview for label-studio-docs-new-theme canceled.
|
Contributor
Author
/git merge
|
bmartel
approved these changes
Oct 11, 2024
yyassi-heartex
approved these changes
Oct 11, 2024
AndrejOros
approved these changes
Oct 14, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ensures padding and border-radius is correct for added textarea regions and corresponding textarea fields
PR fulfills these requirements
[fix|feat|ci|chore|doc]: TICKET-ID: Short description of change made
ex.fix: DEV-XXXX: Removed inconsistent code usage causing intermittent errors
Change has impacts in these area(s)
(check all that apply)
What does this fix?
Padding and border radius missing for Textarea component and its results container.
What is the new behavior?
Textarea and results containers now have expected padding and border radius. CSS variables used now use the values for the corresponding tokens.
Screenshots:
Previous look:


Improved look:

Which logical domain(s) does this change affect?
(for bug fixes/features, be as precise as possible. ex. Authentication, Annotation History, Review Stream etc.)
Label Stream, Review Stream and Labeling Configuration