Skip to content

feat: OPTIC-1217: Implement Color design tokens as CSS variables and Dark Mode #6550

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

yyassi-heartex
Copy link
Contributor

PR fulfills these requirements

  • Commit message(s) and PR title follows the format [fix|feat|ci|chore|doc]: TICKET-ID: Short description of change made ex. fix: DEV-XXXX: Removed inconsistent code usage causing intermittent errors
  • Tests for the changes have been added/updated (for bug fixes/features)
  • Docs have been added/updated (for bug fixes/features)
  • Best efforts were made to ensure docs/code are concise and coherent (checked for spelling/grammatical errors, commented out code, debug logs etc.)
  • Self-reviewed and ran all changes on a local instance (for bug fixes/features)

Change has impacts in these area(s)

(check all that apply)

  • Product design
  • Backend (Database)
  • Backend (API)
  • Frontend

Describe the reason for change

significant improvement to ui tokens + adding the ability to toggle between Auto, Light and Dark mode

@github-actions github-actions bot added the feat label Oct 23, 2024
Copy link

netlify bot commented Oct 23, 2024

Deploy Preview for heartex-docs canceled.

Name Link
🔨 Latest commit 0d2856d
🔍 Latest deploy log https://app.netlify.com/sites/heartex-docs/deploys/680fa67c27edf80008463b28

Copy link

netlify bot commented Oct 23, 2024

Deploy Preview for label-studio-docs-new-theme canceled.

Name Link
🔨 Latest commit 0d2856d
🔍 Latest deploy log https://app.netlify.com/sites/label-studio-docs-new-theme/deploys/680fa67c27edf80008463b2e

@robot-ci-heartex
Copy link
Collaborator

Follow Merge downstream workflow has been failed.

Workflow run

Copy link

codecov bot commented Oct 23, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 78.40%. Comparing base (665f1b5) to head (0d2856d).
Report is 13 commits behind head on develop.

Additional details and impacted files
@@           Coverage Diff            @@
##           develop    #6550   +/-   ##
========================================
  Coverage    78.40%   78.40%           
========================================
  Files          193      193           
  Lines        15624    15624           
========================================
  Hits         12250    12250           
  Misses        3374     3374           
Flag Coverage Δ
pytests 78.40% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@yyassi-heartex
Copy link
Contributor Author

yyassi-heartex commented Oct 23, 2024

/git merge develop

Workflow run
Successfully merged: 7 files changed, 13 insertions(+), 13 deletions(-)

@robot-ci-heartex
Copy link
Collaborator

Follow Merge downstream workflow has been failed.

Workflow run

@robot-ci-heartex
Copy link
Collaborator

Follow Merge downstream workflow has been failed.

Workflow run

@robot-ci-heartex
Copy link
Collaborator

Follow Merge downstream workflow has been failed.

Workflow run

@yyassi-heartex
Copy link
Contributor Author

yyassi-heartex commented Oct 24, 2024

/git merge develop

Workflow run
Successfully merged: create mode 100644 web/apps/labelstudio/src/pages/DataManager/api-config.example.js

@robot-ci-heartex
Copy link
Collaborator

Follow Merge downstream workflow has been failed.

Workflow run

@AndrejOros
Copy link
Contributor

AndrejOros commented Apr 28, 2025

/fm sync

Workflow run

@yyassi-heartex yyassi-heartex merged commit 2e8e35e into develop Apr 28, 2025
51 checks passed
@robot-ci-heartex robot-ci-heartex deleted the fb-optic-1217/implement-design-tokens-as-css-variables branch April 28, 2025 16:47
yyassi-heartex added a commit that referenced this pull request Apr 28, 2025
hlomzik added a commit that referenced this pull request May 12, 2025
They stopped sticking recently. Reverting couple of changes from #6550
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants