-
Notifications
You must be signed in to change notification settings - Fork 2.9k
fix: OPTIC-1287: Project config validation should ignore xml comments #6613
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for heartex-docs canceled.
|
✅ Deploy Preview for label-studio-docs-new-theme canceled.
|
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #6613 +/- ##
===========================================
+ Coverage 76.63% 76.66% +0.02%
===========================================
Files 169 169
Lines 13838 13844 +6
===========================================
+ Hits 10605 10613 +8
+ Misses 3233 3231 -2
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
makseq
requested changes
Nov 7, 2024
Co-authored-by: Max Tkachenko <[email protected]>
…sing to just use the better supported lib
5e1cff8
to
1fdaa04
Compare
makseq
reviewed
Nov 8, 2024
bmartel
commented
Nov 8, 2024
bmartel
commented
Nov 8, 2024
makseq
approved these changes
Nov 8, 2024
AndrejOros
approved these changes
Nov 12, 2024
fredheir
pushed a commit
to ResetNetwork/label-studio
that referenced
this pull request
Jan 1, 2025
…HumanSignal#6613) Co-authored-by: Max Tkachenko <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR fulfills these requirements
[fix|feat|ci|chore|doc]: TICKET-ID: Short description of change made
ex.fix: DEV-XXXX: Removed inconsistent code usage causing intermittent errors
Change has impacts in these area(s)
(check all that apply)
Describe the reason for change
When using xml comments which may contain code samples that have a name property like
<!--document.querySelector('[name="field"]')-->
that also occurs in the label config xml<Taxonomy name="field">
it would fail to validate stating that Config cannot contain non-unique names. This is not correct as the values do not occur within the Label config portion of the xml.Does this PR introduce a breaking change?
(check only one)
What level of testing was included in the change?
(check all that apply)
Which logical domain(s) does this change affect?
Project Config Validation