Skip to content

fix: OPTIC-1341: Filtering on data fields is not working when $undefined$ and other columns in task data #6641

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 11 commits into from
Nov 15, 2024

Conversation

makseq
Copy link
Member

@makseq makseq commented Nov 13, 2024

Change has impacts in these area(s)

(check all that apply)

  • Product design
  • Backend (Database)
  • Backend (API)
  • Frontend

Problem

Data manager filtering does not work for columns different from those in the label config when $undefined$ is in the task data.

Steps to reproduce

Import 2 files (e.g. image) without settings labeling config. You will get 2 tasks.

Patch the first task only with new fields, e.g. add some_value: "my-data" column.

Try using filters by some_value in the data manager, you will see “not found” even if you try to search for “my-data”.

It happens, because the data manager engine forces to use $undefined$ column for search.

Copy link

netlify bot commented Nov 13, 2024

Deploy Preview for heartex-docs canceled.

Name Link
🔨 Latest commit bb5f240
🔍 Latest deploy log https://app.netlify.com/sites/heartex-docs/deploys/67374ebe140d8b00084d5600

Copy link

netlify bot commented Nov 13, 2024

Deploy Preview for label-studio-docs-new-theme canceled.

Name Link
🔨 Latest commit bb5f240
🔍 Latest deploy log https://app.netlify.com/sites/label-studio-docs-new-theme/deploys/67374ebeeed1e6000812dfbf

@github-actions github-actions bot added the fix label Nov 13, 2024
Copy link

codecov bot commented Nov 13, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 76.70%. Comparing base (e6e68f0) to head (bb5f240).
Report is 29 commits behind head on develop.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #6641      +/-   ##
===========================================
+ Coverage    76.67%   76.70%   +0.02%     
===========================================
  Files          169      169              
  Lines        13844    13853       +9     
===========================================
+ Hits         10615    10626      +11     
+ Misses        3229     3227       -2     
Flag Coverage Δ
pytests 76.70% <100.00%> (+0.02%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@makseq makseq enabled auto-merge (squash) November 14, 2024 02:09
@makseq makseq disabled auto-merge November 14, 2024 02:09
@makseq makseq merged commit 20f734f into develop Nov 15, 2024
43 checks passed
@makseq makseq deleted the fb-optic-1341 branch November 15, 2024 14:18
fredheir pushed a commit to ResetNetwork/label-studio that referenced this pull request Jan 1, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants