-
Notifications
You must be signed in to change notification settings - Fork 2.9k
fix: OPTIC-1341: Filtering on data fields is not working when $undefined$ and other columns in task data #6641
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ned$ and other columns in task data
✅ Deploy Preview for heartex-docs canceled.
|
✅ Deploy Preview for label-studio-docs-new-theme canceled.
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #6641 +/- ##
===========================================
+ Coverage 76.67% 76.70% +0.02%
===========================================
Files 169 169
Lines 13844 13853 +9
===========================================
+ Hits 10615 10626 +11
+ Misses 3229 3227 -2
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
triklozoid
approved these changes
Nov 13, 2024
fredheir
pushed a commit
to ResetNetwork/label-studio
that referenced
this pull request
Jan 1, 2025
…ned$ and other columns in task data (HumanSignal#6641)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change has impacts in these area(s)
(check all that apply)
Problem
Data manager filtering does not work for columns different from those in the label config when$undefined$ is in the task data.
Steps to reproduce
Import 2 files (e.g. image) without settings labeling config. You will get 2 tasks.
Patch the first task only with new fields, e.g. add some_value: "my-data" column.
Try using filters by some_value in the data manager, you will see “not found” even if you try to search for “my-data”.
It happens, because the data manager engine forces to use$undefined$ column for search.