-
Notifications
You must be signed in to change notification settings - Fork 2.9k
feat: OPTIC-1553: Add URL-based region visibility, hiding all but the specified region on load #6880
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
bmartel
merged 16 commits into
HumanSignal:develop
from
ddishi:fb/focus-on-region-via-url
Feb 13, 2025
Merged
feat: OPTIC-1553: Add URL-based region visibility, hiding all but the specified region on load #6880
Changes from 11 commits
Commits
Show all changes
16 commits
Select commit
Hold shift + click to select a range
c34697c
Fix `Must provide a proper URL as target` error
ddishi 3fdc2b0
feat: add URL-based region visibility, hiding all but the specified r…
ddishi d461b86
Merge branch 'HumanSignal:develop' into fb/focus-on-region-via-url
ddishi 60374d9
Rename feature flag
ddishi 3173fe7
Merge remote-tracking branch 'origin/develop' into fb/focus-on-region…
bmartel 7ac816f
Add test "should hide all regions except the target region by ID from…
ddishi 1c26af7
Add more test cases and `assertRegionHidden` helper
ddishi 06aa044
Remove the feature flag from the editor folder
ddishi 1a602fe
Applied bmartel suggestion
ddishi e458602
Merge branch 'develop' into fb/focus-on-region-via-url
ddishi 04bb68e
Revert removal of `else` case in `setTask`
ddishi 2d86840
Merge remote-tracking branch 'origin/develop' into fb/focus-on-region…
bmartel 9331b2d
small refactor for clarity, adding selection state so details panel i…
bmartel 6fbc6db
move casing to match other surrounding methods
bmartel df3f7fd
linting
bmartel 4c4c486
Add test: `should select the target region by ID from param`
ddishi File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.