Fix S3 file storage import #6893
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When using cloud storage, a task created from an imported image has a relative URL (e.g., `upload/1/d0672b53-ff-template.jpg`) that breaks when enabling cloud file storage. The fix adds `CustomS3Boto3Storage::url` and utilizes it in the `FileUpload::read_task_from_uploaded_file` to make the app correctly display imported images.
👷 Deploy request for label-studio-docs-new-theme pending review.Visit the deploys page to approve it
|
👷 Deploy request for heartex-docs pending review.Visit the deploys page to approve it
|
|
This PR is stale because it has been open 45 days with no activity. Remove |
|
That is still a problem. Is there anything else I can do to make it merged? |
makseq
approved these changes
Apr 1, 2025
|
@nikitabelonogov could you please create a mirror fb-PR for this one to run all tests? |
|
This PR is stale because it has been open 45 days with no activity. Remove |
|
This PR was closed because it has been stalled for 10 days with no activity. |
makseq
approved these changes
Jun 5, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR fulfills these requirements
[fix|feat|ci|chore|doc]: TICKET-ID: Short description of change madeex.fix: DEV-XXXX: Removed inconsistent code usage causing intermittent errorsI'm not sure what I can do, I don't have a ticket id.
Change has impacts in these area(s)
Describe the reason for change
When using cloud storage, a task created from an imported image has a relative URL (e.g.,
upload/1/d0672b53-ff-template.jpg) that breaks when enabling cloud file storage.What does this fix?
The fix adds
CustomS3Boto3Storage::urland utilizes it in theFileUpload::read_task_from_uploaded_fileto make the app correctly display imported images.What is the new behavior?
When manually importing, the task URL will have
s3://BUCKER_NAME/prefix.What is the current behavior?
The task URL has no prefix (e.g.,
upload/1/d0672b53-ff-template.jpg), so it fails to display in the app.What libraries were added/updated?
NA
Does this change affect performance?
NA
Does this change affect security?
NA
What alternative approaches were there?
The alternative was to resolve to the storage URL when displaying, but using the file storage instance was a more straightforward approach and matched the storage-imported task schema.
What feature flags were used to cover this change?
NA
Does this PR introduce a breaking change?
I'm not sure what was the current setup, but it was clearly not working for cloud file storage, but I can imagine there was a working setup that might get affected, but it is not clear from the source code if there was any.
What level of testing was included in the change?
(check all that apply)
Which logical domain(s) does this change affect?
(for bug fixes/features, be as precise as possible. ex. Authentication, Annotation History, Review Stream etc.)