-
Notifications
You must be signed in to change notification settings - Fork 2.9k
fix: OPTIC-1748: [Timebox] UI polish #7149
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for label-studio-docs-new-theme canceled.
|
✅ Deploy Preview for heartex-docs canceled.
|
…+ comment item tooltip fixes
…s/label-studio into fb-optic-1748/ui-improvements
…1748/ui-improvements" This reverts commit 233340c.
/fm sync |
yyassi-heartex
commented
Mar 7, 2025
web/libs/core/src/pages/AccountSettings/sections/PersonalInfo.tsx
Outdated
Show resolved
Hide resolved
yyassi-heartex
commented
Mar 7, 2025
yyassi-heartex
commented
Mar 7, 2025
yyassi-heartex
commented
Mar 7, 2025
web/libs/core/src/pages/AccountSettings/sections/PersonalInfo.tsx
Outdated
Show resolved
Hide resolved
nick-skriabin
approved these changes
Mar 7, 2025
… + added intent delay
/fm sync |
Contributor
Author
/git merge
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR was automatically generated via Follow Merge. Workflow Run
Please ensure that all linked upstream Pull Requests are merged before proceeding with this one.
various UI improvements and polish including:
PR fulfills these requirements
[fix|feat|ci|chore|doc]: TICKET-ID: Short description of change made
ex.fix: DEV-XXXX: Removed inconsistent code usage causing intermittent errors
Change has impacts in these area(s)
(check all that apply)
This pull request includes multiple changes aimed at refactoring the codebase, specifically focusing on updating import paths and removing deprecated components. The most important changes are grouped by theme below:
Refactoring Import Paths:
Updated import paths for
Tooltip
to use@humansignal/ui
in various components, such asCopyableTooltip
,DescriptionList
,HeidiTip
,MachineLearningList
,PredictionsList
, andStorageSummary
. [1] [2] [3] [4] [5] [6]Updated import paths for
alignElements
andaroundTransition
to use@humansignal/core/lib/utils/dom
and@humansignal/core/lib/utils/transition
respectively inDropdownComponent
andModalPopup
. [1] [2]Updated import paths for
Userpic
to use@humansignal/ui
in various components, such asMenubar
,PeopleList
,SelectedUser
, andProjectsList
. [1] [2] [3] [4]Removal of Deprecated Components:
Removed the
Tooltip
component and its associated styles from the codebase, as it has been replaced by the version from@humansignal/ui
. [1] [2]Removed the
Userpic
component and its associated styles from the codebase, as it has been replaced by the version from@humansignal/ui
. [1] [2]Removed the
alignElements
utility function fromweb/apps/labelstudio/src/utils/dom.js
as it has been moved to@humansignal/core/lib/utils/dom
.Codebase Simplification:
getBoundingBox
andgetAbsolutePosition
functions in the renamed fileweb/libs/core/src/lib/utils/dom.ts
to ensure consistent element positioning logic. [1] [2]These changes collectively aim to streamline the codebase by consolidating utility functions and components into shared libraries, reducing redundancy, and improving maintainability.