Skip to content

fix: OPTIC-1748: [Timebox] UI polish #7149

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 47 commits into from
Mar 10, 2025

Conversation

yyassi-heartex
Copy link
Contributor

@yyassi-heartex yyassi-heartex commented Feb 28, 2025

This PR was automatically generated via Follow Merge. Workflow Run
Please ensure that all linked upstream Pull Requests are merged before proceeding with this one.

various UI improvements and polish including:

  • tooltip and user pic component unification
    • this is to address inconsistencies in usage and visuals for these components
  • text change on the Order by dropdown
  • List/Grid view toggle is now an icon
  • Project card, status icon tooltips
  • fixed an issue affecting datamanger checkboxes when all columns are selected to display, causing them to be duplicated

PR fulfills these requirements

  • Commit message(s) and PR title follows the format [fix|feat|ci|chore|doc]: TICKET-ID: Short description of change made ex. fix: DEV-XXXX: Removed inconsistent code usage causing intermittent errors
  • Tests for the changes have been added/updated (for bug fixes/features)
  • Docs have been added/updated (for bug fixes/features)
  • Best efforts were made to ensure docs/code are concise and coherent (checked for spelling/grammatical errors, commented out code, debug logs etc.)
  • Self-reviewed and ran all changes on a local instance (for bug fixes/features)

Change has impacts in these area(s)

(check all that apply)

  • Product design
  • Backend (Database)
  • Backend (API)
  • Frontend

This pull request includes multiple changes aimed at refactoring the codebase, specifically focusing on updating import paths and removing deprecated components. The most important changes are grouped by theme below:

Refactoring Import Paths:

  • Updated import paths for Tooltip to use @humansignal/ui in various components, such as CopyableTooltip, DescriptionList, HeidiTip, MachineLearningList, PredictionsList, and StorageSummary. [1] [2] [3] [4] [5] [6]

  • Updated import paths for alignElements and aroundTransition to use @humansignal/core/lib/utils/dom and @humansignal/core/lib/utils/transition respectively in DropdownComponent and ModalPopup. [1] [2]

  • Updated import paths for Userpic to use @humansignal/ui in various components, such as Menubar, PeopleList, SelectedUser, and ProjectsList. [1] [2] [3] [4]

Removal of Deprecated Components:

  • Removed the Tooltip component and its associated styles from the codebase, as it has been replaced by the version from @humansignal/ui. [1] [2]

  • Removed the Userpic component and its associated styles from the codebase, as it has been replaced by the version from @humansignal/ui. [1] [2]

  • Removed the alignElements utility function from web/apps/labelstudio/src/utils/dom.js as it has been moved to @humansignal/core/lib/utils/dom.

Codebase Simplification:

  • Simplified the getBoundingBox and getAbsolutePosition functions in the renamed file web/libs/core/src/lib/utils/dom.ts to ensure consistent element positioning logic. [1] [2]

These changes collectively aim to streamline the codebase by consolidating utility functions and components into shared libraries, reducing redundancy, and improving maintainability.

@github-actions github-actions bot added the fix label Feb 28, 2025
Copy link

netlify bot commented Feb 28, 2025

Deploy Preview for label-studio-docs-new-theme canceled.

Name Link
🔨 Latest commit 3c17586
🔍 Latest deploy log https://app.netlify.com/sites/label-studio-docs-new-theme/deploys/67cefb5837e740000807db8f

Copy link

netlify bot commented Feb 28, 2025

Deploy Preview for heartex-docs canceled.

Name Link
🔨 Latest commit 3c17586
🔍 Latest deploy log https://app.netlify.com/sites/heartex-docs/deploys/67cefb58763b160008b8818e

@yyassi-heartex yyassi-heartex requested a review from bmartel March 1, 2025 00:02
@AndrejOros
Copy link
Contributor

AndrejOros commented Mar 7, 2025

/fm sync

Workflow run

@AndrejOros
Copy link
Contributor

AndrejOros commented Mar 10, 2025

/fm sync

Workflow run

@yyassi-heartex
Copy link
Contributor Author

yyassi-heartex commented Mar 10, 2025

/git merge

Workflow run
Successfully merged: create mode 100644 web/apps/labelstudio/src/utils/query-client.ts

@yyassi-heartex yyassi-heartex merged commit fb93625 into develop Mar 10, 2025
34 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants