feat: LEAP-1896: Add scrollbar support to Visualizer #7165
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for heartex-docs canceled.
|
✅ Deploy Preview for label-studio-docs-new-theme canceled.
|
Introduced a scroll filler element to improve handling of browser scroll size inconsistencies in the Visualizer. Updated relevant methods and styles to adjust layout dynamically based on the calculated scroll size. Added safeguards to mouse events.
Gondragos
force-pushed
the
fb-LEAP-1896/audio-scroll
branch
from
003d550 to
046fb9c
Compare
hlomzik
reviewed
Mar 4, 2025
Renamed `BROWSER_SCROLL_SIZE` to `BROWSER_SCROLLBAR_WIDTH` to provide a clearer description of its purpose. Updated related references and comments to reflect this change, ensuring consistency and maintaining accurate documentation.
Gondragos
force-pushed
the
fb-LEAP-1896/audio-scroll
branch
from
162fe3a to
f315f8b
Compare
Refactored scrollbar logic into a new `initScrollBar` method for better clarity and functionality. Added `scrollbarGutter: stable` for potential consistent scrollbar behavior across browsers.
Updated pixel color comparison coordinates in audio region tests to ensure accuracy and consistency. Added a getter to check the readiness of objects in the model and updated `isReady` logic in test helpers for smoother synchronization.
Added a short wait after verifying the loading bar's absence to ensure the AudioView has completely rendered. This change addresses potential flakiness in tests caused by premature assertions.
hlomzik
reviewed
Mar 5, 2025
hlomzik
approved these changes
Mar 5, 2025
bmartel
approved these changes
Mar 5, 2025
|
/git merge
|
It looks like it was not the problem for tests.
|
/git merge develop
|
|
/git merge
|
|
/git merge
|
Replaced redundant full redraw with a targeted cursor update. Added `redrawCursor` method in Visualizer for efficient cursor rendering, enhancing performance and reducing unnecessary visual updates.
Previously, `onReady` was called without considering the `isDrawing` state, which could lead to premature execution. Introduced `checkReady` to delay readiness until drawing completes, ensuring proper timing and avoiding potential issues.
Reordered method calls in the Visualizer update loop to ensure proper rendering. Moved `updateScrollFiller` and `setScrollLeft` to prevent visual inconsistencies. This resolves timing issues when updating the cursor position and timeline.
Gondragos
force-pushed
the
fb-LEAP-1896/audio-scroll
branch
from
169a15e to
b6067dc
Compare
hlomzik
approved these changes
Mar 12, 2025
|
/git merge develop
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Introduced a scroll filler element to improve handling of browser scroll size inconsistencies in the Visualizer. Updated relevant methods and styles to adjust the layout dynamically based on the calculated scroll size. Added safeguards to mouse events.
This pull request introduces several enhancements and fixes to the
VisualizerandWaveformcomponents, as well as some updates to the testing helpers. The most significant changes include the addition of a scrollbar, improvements to theVisualizer's scroll handling, and updates to ensure theAudioUltra's readiness state.Enhancements to Visualizer and Waveform:
BROWSER_SCROLLBAR_WIDTHconstant for dynamic scrollbar width calculation inUtils.ts.scrollFillerelement andinitScrollBarmethod to manage scrollable area size inVisualizer.ts. [1] [2]setScrollLeftand_setScrollLeftmethods to handle scroll position updates inVisualizer.ts.redrawCursormethod to improve synced cursor rendering inVisualizer.ts.centerToCurrentTimemethod to usesetScrollLeftto keep the scrollbar up to date.Improvements to readiness and event handling:
checkReadymethod to ensureWaveformreadiness state inmodel.js. (There were some issues capturing the final drawing state after the audio finished loading, especially in "view all" mode and tests.)syncCursormethod to useredrawCursorfor cursor updates inWaveform.ts. (to avoid redrawing all layers)isDrawinggetter toWaveformfor checking drawing state inWaveform.ts.Testing helpers updates:
waitForObjectsReadycall inisReadymethod to ensure readiness inAudioView.ts. [1] [2]