-
Notifications
You must be signed in to change notification settings - Fork 2.9k
feat: OPTIC-1746: Improve global error message handling by showing toast messages in favour of modals with increased Sentry reporting #7167
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
…ast messages in favour of modals and increased Sentry reporting
✅ Deploy Preview for label-studio-docs-new-theme ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
✅ Deploy Preview for heartex-docs ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
…r of the hook to mock it in order to stop it from causing errors even if unused
/fm sync |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #7167 +/- ##
===========================================
- Coverage 77.20% 77.18% -0.03%
===========================================
Files 187 187
Lines 14484 14491 +7
===========================================
+ Hits 11183 11185 +2
- Misses 3301 3306 +5
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
/fm sync |
…mpty result error key
/fm sync |
…ast messages in favour of modals with increased Sentry reporting (#7167) Co-authored-by: robot-ci-heartex <[email protected]>
…ast messages in favour of modals with increased Sentry reporting (#7167) Co-authored-by: robot-ci-heartex <[email protected]>
This PR was automatically generated via Follow Merge. Workflow Run
Please ensure that all linked upstream Pull Requests are merged before proceeding with this one.
This pull request introduces several changes to streamline error handling and improve the user experience by integrating toast notifications across various components as a replacement of a modal message. There are also improvements to Sentry error tracking of non actionable errors which will no longer be shown to the user through updates to the API provider to handle global error messages more effectively.
UI Enhancements:
ToastProvider
andToastViewport
components toApp.jsx
,Form.jsx
, andModal.jsx
to enable toast notifications which provide a less intrusive way of communicating failures over the previous default of a Modal message. [1] [2] [3] [4] [5] [6] [7]Error Handling Improvements:
captureMessage
andcaptureException
for better error tracking.ApiProvider
to support improved global error messages, including the use of toast notifications for 4xx errors and enhanced error logging to Sentry for non-4xx errors. [1] [2] [3] [4] [5]Testing
Feature Flags:
fflag_feat_front_optic_1746_improve_global_error_messages_short
to control the rollout of these changes.