-
Notifications
You must be signed in to change notification settings - Fork 2.9k
fix: CSP issue by removing unsafe-eval
usage
#7190
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes HumanSignal#7189 Replace the `Function` constructor in the `getProperty` function with a safer implementation. * Use a loop to traverse the object properties based on the provided path. * Remove the usage of `Function` constructor to avoid requiring 'unsafe-eval' in the Content Security Policy. * Return `undefined` if any property in the path is not found. --- For more details, open the [Copilot Workspace session](https://copilot-workspace.githubnext.com/HumanSignal/label-studio/issues/7189?shareId=XXXX-XXXX-XXXX-XXXX).
👷 Deploy request for label-studio-docs-new-theme pending review.Visit the deploys page to approve it
|
👷 Deploy request for heartex-docs pending review.Visit the deploys page to approve it
|
@TylerConlee @bmartel Is there any timeline for considering and merging this PR? 🙏 |
unsafe-eval
usage
/jira create optic
|
✅ Deploy Preview for label-studio-storybook ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
bmartel
approved these changes
Apr 22, 2025
Hi @benglewis ! Could you email me regarding this PR? [email protected] thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #7189
Replace the
Function
constructor in thegetProperty
function with a safer implementation.Function
constructor to avoid requiring 'unsafe-eval' in the Content Security Policy.undefined
if any property in the path is not found.For more details, open the Copilot Workspace session.