-
Notifications
You must be signed in to change notification settings - Fork 2.9k
fix: OPTIC-1749: Limit only sentry_force error logs to go to Sentry #7209
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for heartex-docs canceled.
|
✅ Deploy Preview for label-studio-docs-new-theme canceled.
|
luarmr
approved these changes
Mar 11, 2025
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #7209 +/- ##
========================================
Coverage 77.17% 77.17%
========================================
Files 187 187
Lines 14504 14504
========================================
Hits 11194 11194
Misses 3310 3310
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
/fm sync |
robot-ci-heartex
added a commit
that referenced
this pull request
Mar 12, 2025
…7209) Co-authored-by: robot-ci-heartex <[email protected]>
matt-bernstein
pushed a commit
that referenced
this pull request
Mar 12, 2025
…7209) Co-authored-by: robot-ci-heartex <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In #7187 we let error logs go to sentry, but this caused an overflow of issues that aren't errors. As an alternative, we'll send error logs only when they have exceptions (current behavior) or when they are forced.