Skip to content

fix: OPTIC-1749: Limit only sentry_force error logs to go to Sentry #7209

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Mar 11, 2025

Conversation

mcanu
Copy link
Contributor

@mcanu mcanu commented Mar 11, 2025

In #7187 we let error logs go to sentry, but this caused an overflow of issues that aren't errors. As an alternative, we'll send error logs only when they have exceptions (current behavior) or when they are forced.

@github-actions github-actions bot added the fix label Mar 11, 2025
Copy link

netlify bot commented Mar 11, 2025

Deploy Preview for heartex-docs canceled.

Name Link
🔨 Latest commit 36f9904
🔍 Latest deploy log https://app.netlify.com/sites/heartex-docs/deploys/67d0a8d113e8f40008fc539e

Copy link

netlify bot commented Mar 11, 2025

Deploy Preview for label-studio-docs-new-theme canceled.

Name Link
🔨 Latest commit 36f9904
🔍 Latest deploy log https://app.netlify.com/sites/label-studio-docs-new-theme/deploys/67d0a8d113e8f40008fc53a0

Copy link

codecov bot commented Mar 11, 2025

Codecov Report

Attention: Patch coverage is 0% with 2 lines in your changes missing coverage. Please review.

Project coverage is 77.17%. Comparing base (25f84b6) to head (36f9904).
Report is 1 commits behind head on develop.

Files with missing lines Patch % Lines
label_studio/core/utils/sentry.py 0.00% 1 Missing ⚠️
label_studio/projects/functions/next_task.py 0.00% 1 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff            @@
##           develop    #7209   +/-   ##
========================================
  Coverage    77.17%   77.17%           
========================================
  Files          187      187           
  Lines        14504    14504           
========================================
  Hits         11194    11194           
  Misses        3310     3310           
Flag Coverage Δ
pytests 77.17% <0.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@mcanu
Copy link
Contributor Author

mcanu commented Mar 11, 2025

/fm sync

Workflow run

@mcanu mcanu merged commit 3a91538 into develop Mar 11, 2025
42 of 43 checks passed
robot-ci-heartex added a commit that referenced this pull request Mar 12, 2025
matt-bernstein pushed a commit that referenced this pull request Mar 12, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants