fix: OPTIC-1794: Improve handling of missing tasks and projects when fetching data within DataManager

web/apps/labelstudio/src/pages/DataManager/DataManager.jsx

@@ -14,7 +14,7 @@ import { isDefined } from "../../utils/helpers";
 import { ImportModal } from "../CreateProject/Import/ImportModal";
 import { ExportPage } from "../ExportPage/ExportPage";
 import { APIConfig } from "./api-config";
-import { ToastContext } from "@humansignal/ui";
+import { ToastContext, ToastType } from "@humansignal/ui";
 import { FF_OPTIC_2, isFF } from "../../utils/feature-flags";
 
 import "./DataManager.scss";
@@ -96,7 +96,27 @@ export const DataManagerPage = ({ ...props }) => {
 
     Object.assign(window, { dataManager });
 
-    dataManager.on("crash", () => setCrashed());
+    dataManager.on("crash", (details) => {
+      const error = details?.error;
+      const isMissingTaskError = error?.startsWith("Task ID:");
+      const isMissingProjectError = error?.startsWith("Project ID:");
+
+      if (isMissingTaskError || isMissingProjectError) {
+        toast.show({
+          message: `The ${
+            isMissingTaskError ? "task" : "project"
+          } you are trying to access does not exist or is no longer available.`,
+          type: ToastType.error,
+          duration: 10000,
+        });
+      }
+
+      if (isMissingTaskError) {
+        history.push(buildLink("", { id: params.id }));
+      } else if (isMissingProjectError) {
+        history.push("/projects");
+      }
+    });
 
     dataManager.on("settingsClicked", () => {
       history.push(buildLink("/settings/labeling", { id: params.id }));
@@ -122,7 +142,7 @@ export const DataManagerPage = ({ ...props }) => {
       const target = route.replace(/^projects/, "");
 
       if (target) history.push(buildLink(target, { id: params.id }));
-      else history.push("/projects/");
+      else history.push("/projects");
     });
 
     if (interactiveBacked) {

web/libs/datamanager/src/stores/AppStore.js

@@ -484,17 +484,18 @@ export const AppStore = types
       try {
         const newProject = yield self.apiCall("project", params);
         const projectLength = Object.entries(self.project ?? {}).length;
+        const newProjectLength = Object.entries(newProject ?? {}).length;
 
         self.needsDataFetch =
-          options.force !== true && projectLength > 0
+          options.force !== true && projectLength > 0 && newProjectLength > 0
             ? self.project.task_count !== newProject.task_count ||
               self.project.task_number !== newProject.task_number ||
               self.project.annotation_count !== newProject.annotation_count ||
               self.project.num_tasks_with_annotations !== newProject.num_tasks_with_annotations
             : false;
 
         if (options.interaction === "timer") {
-          self.project = Object.assign(self.project ?? {}, newProject);
+          self.project = Object.assign(self.project ?? {}, newProject ?? {});
         } else if (JSON.stringify(newProject ?? {}) !== JSON.stringify(self.project ?? {})) {
           self.project = newProject;
         }
@@ -504,7 +505,15 @@ export const AppStore = types
           self.SDK.invoke(`${itemType}Updated`, self.project);
         }
       } catch {
-        self.crash();
+        // When in timer (polling project counts) mode, we can still continue
+        // but we need to crash for non-polling interactions
+        // because we can't display the app without the project itself and will need to redirect
+        if (options.interaction !== "timer") {
+          self.crash({
+            error: `Project ID: ${self.SDK.projectId} does not exist or is no longer available`,
+            redirect: true,
+          });
+        }
         return false;
       }
       self.projectFetch = false;
@@ -622,7 +631,9 @@ export const AppStore = types
         result.isCanceled = signal.aborted;
         self.requestsInFlight.delete(requestKey);
       }
-      if (result.error && result.status !== 404 && !signal.aborted) {
+      // We don't want to show errors when loading data in polling mode
+      // we will just allow it to try again later
+      if (result.error && result.status !== 404 && !signal.aborted && params.interaction !== "timer") {
         if (options?.errorHandler?.(result)) {
           return result;
         }
@@ -739,10 +750,12 @@ export const AppStore = types
       return result;
     }),
 
-    crash() {
-      self.destroy();
-      self.crashed = true;
-      self.SDK.invoke("crash");
+    crash(options = {}) {
+      if (options.redirect !== true) {
+        self.destroy();
+        self.crashed = true;
+      }
+      self.SDK.invoke("crash", options);
     },
 
     destroy() {

web/libs/datamanager/src/stores/DataStores/tasks.js

@@ -145,8 +145,19 @@ export const create = (columns) => {
 
         self.setLoading(taskID);
 
-        const taskData = yield self.root.apiCall("task", { taskID });
+        const taskData = yield self.root.apiCall("task", { taskID }, undefined, { allowToCancel: true });
 
+        if (taskData.isCanceled) {
+          return null;
+        }
+        if (taskData.status === 404) {
+          self.finishLoading(taskID);
+          getRoot(self).SDK.invoke("crash", {
+            error: `Task ID: ${taskID} does not exist or is no longer available`,
+            redirect: true,
+          });
+          return null;
+        }
         const task = self.applyTaskSnapshot(taskData, taskID);
 
         if (select !== false) self.setSelected(task);