Skip to content

fix: OPTIC-1850: 'n is not a function' RUNTIME error occur on ls-develop when user tries to create a project #7273

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Mar 25, 2025

Conversation

yyassi-heartex
Copy link
Contributor

@yyassi-heartex yyassi-heartex commented Mar 24, 2025

due to the upgrade to react 18 - we need to make sure that if a useEffect function only gets a destroy function when appropriate. we have use cases that shouldnt be returning to useEffect so we update it here

@github-actions github-actions bot added the fix label Mar 24, 2025
Copy link

netlify bot commented Mar 24, 2025

Deploy Preview for heartex-docs canceled.

Name Link
🔨 Latest commit 675e898
🔍 Latest deploy log https://app.netlify.com/sites/heartex-docs/deploys/67e260282d93e40008b498a5

Copy link

netlify bot commented Mar 24, 2025

Deploy Preview for label-studio-docs-new-theme canceled.

Name Link
🔨 Latest commit 675e898
🔍 Latest deploy log https://app.netlify.com/sites/label-studio-docs-new-theme/deploys/67e26028cce1a20008c5921d

Copy link

netlify bot commented Mar 24, 2025

Deploy Preview for label-studio-storybook canceled.

Name Link
🔨 Latest commit 675e898
🔍 Latest deploy log https://app.netlify.com/sites/label-studio-storybook/deploys/67e260282aff6a000808d150

@nick-skriabin
Copy link
Member

lgtm!

@AndrejOros
Copy link
Contributor

AndrejOros commented Mar 25, 2025

/fm sync

Workflow run

@yyassi-heartex yyassi-heartex merged commit 1114b3b into develop Mar 25, 2025
38 checks passed
@robot-ci-heartex robot-ci-heartex deleted the fb-optic-1850/useeffect-return branch March 25, 2025 10:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants