Skip to content

fix: OPTIC-1827: Fix information exposure through exception when validating S3 connection #7310

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Apr 4, 2025

Conversation

mcanu
Copy link
Contributor

@mcanu mcanu commented Mar 31, 2025

Stop displaying error exception to user and exposing internal info. Added logging for tracking internally.

@github-actions github-actions bot added the fix label Mar 31, 2025
Copy link

netlify bot commented Mar 31, 2025

Deploy Preview for label-studio-storybook canceled.

Name Link
🔨 Latest commit c8e2c4c
🔍 Latest deploy log https://app.netlify.com/sites/label-studio-storybook/deploys/67f019358353120008f832e1

Copy link

netlify bot commented Mar 31, 2025

Deploy Preview for heartex-docs canceled.

Name Link
🔨 Latest commit c8e2c4c
🔍 Latest deploy log https://app.netlify.com/sites/heartex-docs/deploys/67f019356692c400080c107f

Copy link

netlify bot commented Mar 31, 2025

Deploy Preview for label-studio-docs-new-theme canceled.

Name Link
🔨 Latest commit c8e2c4c
🔍 Latest deploy log https://app.netlify.com/sites/label-studio-docs-new-theme/deploys/67f0193551a73300084f4afb

@mcanu mcanu requested a review from wesleylima March 31, 2025 15:06
Copy link

codecov bot commented Mar 31, 2025

Codecov Report

Attention: Patch coverage is 50.00000% with 2 lines in your changes missing coverage. Please review.

Project coverage is 77.32%. Comparing base (a521eaa) to head (c8e2c4c).
Report is 3 commits behind head on develop.

Files with missing lines Patch % Lines
label_studio/io_storages/s3/serializers.py 50.00% 2 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #7310      +/-   ##
===========================================
- Coverage    77.33%   77.32%   -0.01%     
===========================================
  Files          188      188              
  Lines        14605    14608       +3     
===========================================
+ Hits         11295    11296       +1     
- Misses        3310     3312       +2     
Flag Coverage Δ
pytests 77.32% <50.00%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@mcanu
Copy link
Contributor Author

mcanu commented Apr 4, 2025

/fm sync

Workflow run

@mcanu mcanu merged commit 9c14247 into develop Apr 4, 2025
46 of 48 checks passed
@robot-ci-heartex robot-ci-heartex deleted the fb-optic-1827 branch April 4, 2025 18:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants