Skip to content

fix: LEAP-1919: update origin on editing classifications results #7312

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 9 commits into from
Apr 9, 2025

Conversation

Gondragos
Copy link
Collaborator

Description

This update ensures prediction results origins are consistently updated to "prediction-changed" when user edits are made to classification results. It includes:

  • A new updateOriginOnEdit() method in Regions.js for handling origin updates.
  • Adjustments to ToolBar controls to better support actions like annotation duplication.
  • Integration tests verifying that predictions are updated correctly post-edit.

Reason for Change

Previously, user edits did not update the origin value consistently, leading to potential data inconsistencies. This fix ensures user actions are accurately reflected in prediction metadata.

Testing

Integration tests have been implemented to verify proper behavior under various scenarios of user editing.

Ensure prediction origins are updated to "prediction-changed" upon user edits.
- Added `updateOriginOnEdit()` method in `Regions.js` to handle origin updates.
- Improved `ToolBar` controls to manage actions like duplicating annotations.
- Introduced integration tests to validate correct origin updates for predictions.
@github-actions github-actions bot added the fix label Apr 1, 2025
Copy link

netlify bot commented Apr 1, 2025

Deploy Preview for label-studio-storybook canceled.

Name Link
🔨 Latest commit 8321a28
🔍 Latest deploy log https://app.netlify.com/sites/label-studio-storybook/deploys/67f6719e9c249b000883c58a

Copy link

netlify bot commented Apr 1, 2025

Deploy Preview for heartex-docs ready!

Name Link
🔨 Latest commit 8321a28
🔍 Latest deploy log https://app.netlify.com/sites/heartex-docs/deploys/67f6719e74934e0008e4032d
😎 Deploy Preview https://deploy-preview-7312--heartex-docs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

netlify bot commented Apr 1, 2025

Deploy Preview for label-studio-docs-new-theme ready!

Name Link
🔨 Latest commit 8321a28
🔍 Latest deploy log https://app.netlify.com/sites/label-studio-docs-new-theme/deploys/67f6719ea934960008c0beaf
😎 Deploy Preview https://deploy-preview-7312--label-studio-docs-new-theme.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@Gondragos Gondragos requested review from nass600 and hlomzik April 1, 2025 12:58
@Gondragos Gondragos changed the title fix: update origin on editing classifications results fix: LEAP-1919: update origin on editing classifications results Apr 3, 2025
@Gondragos
Copy link
Collaborator Author

Gondragos commented Apr 3, 2025

/git merge

Workflow run
Successfully merged: create mode 100644 web/libs/ui/src/shadcn.ts

@MihajloHoma
Copy link
Contributor

MihajloHoma commented Apr 4, 2025

/git merge

Workflow run
Successfully merged: 3 files changed, 73 insertions(+), 14 deletions(-)

@MihajloHoma
Copy link
Contributor

MihajloHoma commented Apr 4, 2025

/fm sync

Workflow run

@Gondragos
Copy link
Collaborator Author

Gondragos commented Apr 7, 2025

/git merge

Workflow run
Successfully merged: create mode 100644 label_studio/users/product_tours/configs/show_ask_ai.yml

@Gondragos
Copy link
Collaborator Author

Gondragos commented Apr 7, 2025

/git merge

Workflow run
Successfully merged: 2 files changed, 2 insertions(+), 2 deletions(-)

@Gondragos
Copy link
Collaborator Author

Gondragos commented Apr 8, 2025

/git merge

Workflow run
Successfully merged: create mode 100644 docs/themes/v2/source/images/storages/s3-trust-policy.png

Gondragos and others added 2 commits April 8, 2025 12:18
Implemented a new end-to-end test to verify the correct behavior of the undo feature in Label Studio. The test ensures that annotations revert to their predicted state after multiple undo actions. Added Hotkeys helper to simulate undo operations.
@Gondragos
Copy link
Collaborator Author

Gondragos commented Apr 8, 2025

/git merge

Workflow run
Successfully merged: Already up to date.

@Gondragos
Copy link
Collaborator Author

Gondragos commented Apr 9, 2025

/git merge

Workflow run
Successfully merged: 384 files changed, 56 insertions(+), 4785 deletions(-)

@Gondragos Gondragos merged commit 0ee26ca into develop Apr 9, 2025
40 checks passed
@robot-ci-heartex robot-ci-heartex deleted the fb-LEAP-1919/classification-prediction branch April 9, 2025 14:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants