Skip to content

fix: LEAP-1997: make CORS configurable via env #7448

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
May 2, 2025

Conversation

jombooth
Copy link
Contributor

@jombooth jombooth commented Apr 30, 2025

see Configuration: https://pypi.org/project/django-cors-headers/

confirmed that

curl -i 'https://fb-leap-1997-configurable.appx.humansignal.com/api/current-user/whoami' [REDACTED] 'Origin: https://example.org'

will include

access-control-allow-origin: https://example.org

in its returned headers, if https://example.org is set as one of the CORS_ALLOWED_ORIGINS.

This also adds origin header logging to the LS nginx config.

Copy link

netlify bot commented Apr 30, 2025

Deploy Preview for label-studio-storybook canceled.

Name Link
🔨 Latest commit 5494fc5
🔍 Latest deploy log https://app.netlify.com/sites/label-studio-storybook/deploys/6814025168fbfc0008bda8a7

Copy link

netlify bot commented Apr 30, 2025

Deploy Preview for label-studio-docs-new-theme canceled.

Name Link
🔨 Latest commit 5494fc5
🔍 Latest deploy log https://app.netlify.com/sites/label-studio-docs-new-theme/deploys/681402512497c80008b8dd0e

@jombooth jombooth changed the title Fb leap 1997/configurable cors fix: LEAP-1997: make CORS configurable via env Apr 30, 2025
Copy link

netlify bot commented Apr 30, 2025

Deploy Preview for heartex-docs canceled.

Name Link
🔨 Latest commit 5494fc5
🔍 Latest deploy log https://app.netlify.com/sites/heartex-docs/deploys/68140251a9b16b00089910d9

Copy link

codecov bot commented Apr 30, 2025

Codecov Report

Attention: Patch coverage is 60.00000% with 2 lines in your changes missing coverage. Please review.

Project coverage is 77.79%. Comparing base (59feca7) to head (5494fc5).
Report is 1 commits behind head on develop.

Files with missing lines Patch % Lines
label_studio/core/settings/base.py 60.00% 2 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #7448      +/-   ##
===========================================
- Coverage    77.80%   77.79%   -0.01%     
===========================================
  Files          195      195              
  Lines        15768    15772       +4     
===========================================
+ Hits         12268    12270       +2     
- Misses        3500     3502       +2     
Flag Coverage Δ
pytests 77.79% <60.00%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@jombooth jombooth requested a review from a team as a code owner May 1, 2025 15:52
@jombooth jombooth enabled auto-merge (squash) May 1, 2025 16:21
@jombooth
Copy link
Contributor Author

jombooth commented May 1, 2025

/git merge develop

Workflow run
Successfully merged: delete mode 100644 web/dist/libs/editor/version.json

@jombooth
Copy link
Contributor Author

jombooth commented May 1, 2025

/git merge develop

Workflow run
Successfully merged: Already up to date.

@jombooth
Copy link
Contributor Author

jombooth commented May 1, 2025

/git merge develop

Workflow run
Successfully merged: 1 file changed, 2 insertions(+)

@jombooth
Copy link
Contributor Author

jombooth commented May 2, 2025

/git merge develop

Workflow run
Successfully merged: Already up to date.

@jombooth jombooth merged commit a00231a into develop May 2, 2025
45 of 47 checks passed
@robot-ci-heartex robot-ci-heartex deleted the fb-LEAP-1997/configurable-cors branch May 2, 2025 03:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants