fix: OPTIC-2157: Actions Menu Disappears at High Browser Zoom Levels #7479
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for heartex-docs canceled.
|
✅ Deploy Preview for label-studio-docs-new-theme canceled.
|
bmartel
reviewed
May 6, 2025
bmartel
reviewed
May 6, 2025
web/libs/datamanager/src/components/Common/Dropdown/DropdownComponent.jsx
Outdated
Show resolved
Hide resolved
✅ Deploy Preview for label-studio-storybook ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
bmartel
approved these changes
May 6, 2025
nass600
reviewed
May 7, 2025
|
/fm sync |
|
/git merge
|
jombooth
pushed a commit
that referenced
this pull request
May 12, 2025
…7479) Co-authored-by: bmartel <[email protected]> Co-authored-by: vladimirheartex <[email protected]> Co-authored-by: yyassi-heartex <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request introduces changes to improve the alignment logic for dropdown elements in scenarios with limited viewport height. It adds a new parameter,
openUpwardForShortViewport, to control whether dropdowns should open upward when there is insufficient space below. Debuggingconsole.logstatements have also been added for troubleshooting.Alignment logic enhancements:
web/libs/core/src/lib/utils/dom.ts: Added a new parameteropenUpwardForShortViewportto thealignElementsfunction, defaulting totrue. Updated the alignment logic to consider this parameter when determining whether to align dropdowns upward or downward. [1] [2]Debugging improvements:
web/libs/core/src/lib/utils/dom.ts: Added aconsole.logstatement to log alignment calculations, includingoffsetTop,openUpwardForShortViewport, and other related variables.web/libs/datamanager/src/components/Common/Dropdown/DropdownComponent.jsx: Added aconsole.logstatement to log the value ofopenUpwardForShortViewportduring position calculation in theDropdowncomponent.