fix: OPTIC-2144: Toggle interpolation button is not optimized dark mode #7485
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for heartex-docs canceled.
|
✅ Deploy Preview for label-studio-docs-new-theme canceled.
|
✅ Deploy Preview for label-studio-storybook ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
yyassi-heartex
approved these changes
May 7, 2025
ricardoantoniocm
changed the title
|
/fm sync |
…n-is-not-optimized-dark-mode' Workflow run: https://github.com/HumanSignal/label-studio/actions/runs/14900937459
|
/fm sync |
|
/git merge
|
…n-is-not-optimized-dark-mode' Workflow run: https://github.com/HumanSignal/label-studio/actions/runs/14931175197
|
/git merge
|
…n-is-not-optimized-dark-mode' Workflow run: https://github.com/HumanSignal/label-studio/actions/runs/14932479048
robot-ci-heartex
deleted the
fb-optic-2144/toggle-interpolation-button-is-not-optimized-dark-mode
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reason for change:
The "Toggle Interpolation" button in Label Studio was not optimized for Dark Mode. When in the OFF state, the button appeared as a solid black shape, making it difficult to discern its state and functionality. This PR addresses this issue by ensuring the button is correctly styled for both ON and OFF states in both Light and Dark Mode.
Solution:
The fix involves changing the button's color from a fixed black value to currentColor. This allows the button's color to be determined by the surrounding context (e.g., the text color), ensuring it adapts correctly to the active color scheme (Light or Dark Mode).
Screenshots:
Before:
After:
Testing:
The following steps were used to verify the fix:
Risks:
This change is limited to the styling of a single button. There is minimal risk of introducing regressions.
Reviewer notes:
Please pay close attention to the button's appearance in both Light and Dark Mode, and in both ON and OFF states.
General notes:
This fix ensures a better user experience by providing consistent and clear visual feedback for the "Toggle Interpolation" button, regardless of the user's chosen color scheme.