-
Notifications
You must be signed in to change notification settings - Fork 2.9k
fix: OPTIC-2152: Zoom presets option hotkeys not optimized for dark mode #7490
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: OPTIC-2152: Zoom presets option hotkeys not optimized for dark mode #7490
Conversation
…optimized for Dark mode
…e flyout menu option shortcut key binding look and feel.
✅ Deploy Preview for label-studio-docs-new-theme ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
✅ Deploy Preview for heartex-docs ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
✅ Deploy Preview for label-studio-storybook ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
A PR addressing visual inconsistencies in the hotkey styling for the Zoom Presets menu to improve appearance in dark mode.
- Updated background colors from var(--color-neutral-background) to var(--color-neutral-surface)
- Adjusted padding, margins, and box-shadow settings for improved alignment and a physical key look
- Revised flex layout and removed opacity styling for a clearer, more consistent visual presentation
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
File | Description |
---|---|
web/libs/editor/src/components/Toolbar/Tool.scss | Updated background, padding, and box-shadow for hotkey styling |
web/libs/editor/src/components/Toolbar/FlyoutMenu.scss | Adjusted layout (flex-direction and margins), removed opacity from shortcuts, and refined key element styling |
Comments suppressed due to low confidence (1)
web/libs/editor/src/components/Toolbar/FlyoutMenu.scss:185
- [nitpick] It may be helpful to add a comment clarifying the intent behind removing the opacity on the __shortcut element, so future reviewers understand this design decision.
// Removed: opacity: 0.6;
Co-authored-by: Copilot <[email protected]>
/git merge
|
…timized-for-dark-mode' Workflow run: https://github.com/HumanSignal/label-studio/actions/runs/14932391987
Reason for change
The Zoom Preset menu displays hotkeys with a color scheme that is inconsistent with other tools in the application and is not optimized for dark mode, making them nearly invisible in dark mode. This PR addresses these inconsistencies and introduces a new, consistent visual style for all image tool hotkeys, improving usability and aesthetics in both light and dark modes. The changes include adjustments to sizing, colors, and alignment to ensure hotkeys appear as physical keys and are consistently right-aligned.
Screenshots
Before:




After:




Rollout strategy
This change involves only front-end visual updates and does not require a phased rollout or feature flags. The changes will be deployed with the next application release.
Testing
The following testing steps were performed to verify the changes:
Risks
There are minimal risks associated with this change as it primarily involves visual styling. However, potential risks include:
Reviewer notes
Please pay close attention to the following during the review:
General notes
The new hotkey style is designed to mimic the appearance of physical keys, providing a more intuitive visual cue for users. This update improves the overall user experience by enhancing consistency and accessibility across the application.