-
Notifications
You must be signed in to change notification settings - Fork 2.9k
fix: OPTIC-2155: Info tab is not optimized for dark mode for TimeSeriesLabel with underlying Choices #7492
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: OPTIC-2155: Info tab is not optimized for dark mode for TimeSeriesLabel with underlying Choices #7492
Conversation
…iesLabel is selected
…a nested Choices element is selected.
✅ Deploy Preview for label-studio-docs-new-theme canceled.
|
✅ Deploy Preview for heartex-docs canceled.
|
✅ Deploy Preview for label-studio-storybook ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR fixes an issue with dark mode readability in the Info tab for TimeSeriesLabel selections by updating the text and background colors, as well as the padding and border radius for improved visual consistency.
- Updated the text color for primary elements to use the neutral content token.
- Modified the nested styling for the .ant-typography mark element to ensure proper background contrast and padding.
web/libs/editor/src/components/SidePanels/DetailsPanel/RegionDetails.scss
Show resolved
Hide resolved
/fm sync |
/git merge
|
Reason for change
The text displayed in the Info tab for TimeSeriesLabel selections was not optimized for dark mode, resulting in black text on a dark background, which reduces readability. This change addresses this issue by ensuring the text color adapts appropriately for both light and dark modes, improving the user experience.
Screenshots
Before:


After:


Rollout strategy
This is a small visual change and does not require a specific rollout strategy. The changes will be deployed with the next release.
Testing
Verify Dark Mode:
color-neutral-content
color).color-primary-background
) providing sufficient contrast.Verify Light Mode:
Risks
There are minimal risks associated with this change as it primarily involves styling adjustments. However, potential risks include:
Reviewer notes
General notes
color-neutral-content
token.color-primary-background
token.