Skip to content

fix: OPTIC-2155: Info tab is not optimized for dark mode for TimeSeriesLabel with underlying Choices #7492

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

ricardoantoniocm
Copy link
Contributor

@ricardoantoniocm ricardoantoniocm commented May 7, 2025

Reason for change

The text displayed in the Info tab for TimeSeriesLabel selections was not optimized for dark mode, resulting in black text on a dark background, which reduces readability. This change addresses this issue by ensuring the text color adapts appropriately for both light and dark modes, improving the user experience.

Screenshots

Before:
image
image

After:
image
image

Rollout strategy

This is a small visual change and does not require a specific rollout strategy. The changes will be deployed with the next release.

Testing

  1. Verify Dark Mode:

    • Navigate to the LSO/LSE application in dark mode.
    • Create a project with the "Signal Quality" template.
    • Create a label, select it and choose an option from the Choices.
    • Open the Info tab.
    • Confirm that the text for both the key and value pairs is easily readable against the dark background (using the color-neutral-content color).
    • Confirm that the background of the value is a lighter color (color-primary-background) providing sufficient contrast.
    • Verify the added padding and rounded corners improve the visual consistency.
  2. Verify Light Mode:

    • Switch to Light Mode.
    • Confirm that the text and background colors in the Info tab are appropriate and readable in light mode.

Risks

There are minimal risks associated with this change as it primarily involves styling adjustments. However, potential risks include:

  • Unexpected visual regressions: The new styles might inadvertently affect other elements in the application. Thorough testing in both light and dark modes should mitigate this.

Reviewer notes

  • Please pay close attention to the contrast ratio between the text and background in both light and dark modes to ensure accessibility.
  • Verify that the added padding and rounded corners are applied consistently with other similar elements in the application.
  • Confirm that no other unintended visual changes have been introduced.

General notes

  • The text color for the key and value pairs has been set to the color-neutral-content token.
  • The background color for the value has been set to the color-primary-background token.
  • Padding and rounded corners have been added to the value for better visual consistency.

Copy link

netlify bot commented May 7, 2025

Deploy Preview for label-studio-docs-new-theme canceled.

Name Link
🔨 Latest commit 4c5b09b
🔍 Latest deploy log https://app.netlify.com/sites/label-studio-docs-new-theme/deploys/681e1fa9b6471400089be211

Copy link

netlify bot commented May 7, 2025

Deploy Preview for heartex-docs canceled.

Name Link
🔨 Latest commit 4c5b09b
🔍 Latest deploy log https://app.netlify.com/sites/heartex-docs/deploys/681e1fa9c2ac2e00082125f4

Copy link

netlify bot commented May 7, 2025

Deploy Preview for label-studio-storybook ready!

Name Link
🔨 Latest commit 4c5b09b
🔍 Latest deploy log https://app.netlify.com/sites/label-studio-storybook/deploys/681e1fa91a8a6b00087b08b8
😎 Deploy Preview https://deploy-preview-7492--label-studio-storybook.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@ricardoantoniocm ricardoantoniocm requested a review from bmartel May 7, 2025 21:27
@github-actions github-actions bot added the fix label May 7, 2025
Copy link
Contributor

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR fixes an issue with dark mode readability in the Info tab for TimeSeriesLabel selections by updating the text and background colors, as well as the padding and border radius for improved visual consistency.

  • Updated the text color for primary elements to use the neutral content token.
  • Modified the nested styling for the .ant-typography mark element to ensure proper background contrast and padding.

@AndrejOros
Copy link
Contributor

AndrejOros commented May 8, 2025

/fm sync

Workflow run

@ricardoantoniocm
Copy link
Contributor Author

ricardoantoniocm commented May 9, 2025

/git merge

Workflow run
Successfully merged: rename web/libs/datamanager/src/components/App/{App.jsx => App.tsx} (73%)

@ricardoantoniocm ricardoantoniocm merged commit 1c37a5a into develop May 9, 2025
38 checks passed
@robot-ci-heartex robot-ci-heartex deleted the fb-optic-2155/info-tab-is-not-optimized-for-dark-mode branch May 9, 2025 16:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants