Skip to content

fix: OPTIC-2146: PerRegion TextArea input is barely visible in dark mode #7513

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

ricardoantoniocm
Copy link
Contributor

Reason for change

The text entered into the perRegion TextArea input field was barely visible when the application was in Dark Mode. This was due to the text color not having sufficient contrast against the background color of the textarea. The fix involves updating the CSS for the textarea input in Dark Mode to ensure the text is clearly visible. Specifically, the text color is now explicitly set to a color that provides better contrast against the dark background.

Other improvements were made to ensure the default, hover and focus states of the TextArea input match the overall look and feel of the application (border-color, focus outline, etc).

Screenshots

Before:
image

After:
image

Rollout strategy

No specific rollout strategy is required for this change as it is a small visual fix.

Testing

The following steps were performed to verify the fix (data provided didn't work for Quick View):

  1. Logged in as OWNER to LSE.
  2. Navigated to a project using the Optical Character Recognition template.
  3. Opened the Labeling configuration and toggled Advanced Mode ON.
  4. Added a region.
  5. Selected the region and entered text into the TextArea under the corresponding region.
  6. Confirmed that the entered text is now clearly visible against the dark background of the TextArea.

Risks

The risk associated with this change is minimal as it only involves a CSS modification to improve text visibility. There are no anticipated functional regressions.

Reviewer notes

Please verify that the CSS changes in web/libs/editor/src/tags/control/TextArea/TextArea.scss correctly address the contrast issue in Dark Mode and do not introduce any unintended visual side effects in other themes or parts of the application.

Copy link

netlify bot commented May 12, 2025

Deploy Preview for label-studio-docs-new-theme canceled.

Name Link
🔨 Latest commit 84e2d72
🔍 Latest deploy log https://app.netlify.com/sites/label-studio-docs-new-theme/deploys/68224eb8aad5e00008daf2db

Copy link

netlify bot commented May 12, 2025

Deploy Preview for label-studio-storybook ready!

Name Link
🔨 Latest commit 84e2d72
🔍 Latest deploy log https://app.netlify.com/sites/label-studio-storybook/deploys/68224eb828666b0008245d8d
😎 Deploy Preview https://deploy-preview-7513--label-studio-storybook.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

netlify bot commented May 12, 2025

Deploy Preview for heartex-docs canceled.

Name Link
🔨 Latest commit 84e2d72
🔍 Latest deploy log https://app.netlify.com/sites/heartex-docs/deploys/68224eb81dd1210008ee28b9

@github-actions github-actions bot added the fix label May 12, 2025
@ricardoantoniocm ricardoantoniocm merged commit 7e7a119 into develop May 12, 2025
38 checks passed
@robot-ci-heartex robot-ci-heartex deleted the fb-optic-2146/perregion-textarea-input-is-barely-visible-in-dark-mode branch May 12, 2025 22:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants