-
Notifications
You must be signed in to change notification settings - Fork 2.9k
feat: BROS-44: Add MultiChannel tag support for TimeSeries #7669
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
- Introduced a feature flag `FF_MULTICHANNEL_TS` to enable multi-channel functionality in the TimeSeries component. - Added new tag `MultiChannel` for grouping channels on one plot. - Added `ChannelLegend` and `TimeSeriesVisualizer` components for improved visualization and interaction. - Updated the `Channel` model and several associated functionalities to support multi-channel rendering.
✅ Deploy Preview for label-studio-docs-new-theme canceled.
|
✅ Deploy Preview for label-studio-storybook ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
✅ Deploy Preview for heartex-docs canceled.
|
✅ Deploy Preview for label-studio-playground ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
- Introduced a palette of color tokens for consistent styling. - Added functionality to assign colors dynamically to stroke and marker properties of channels. - Updated `MultiChannel` and `TimeSeries` components to utilize the new dynamic color logic.
/git merge
|
Allow to collect all columns
Codecov ReportAttention: Patch coverage is
✅ All tests successful. No failed tests found.
Additional details and impacted files@@ Coverage Diff @@
## develop #7669 +/- ##
===========================================
- Coverage 78.94% 78.84% -0.11%
===========================================
Files 205 205
Lines 16314 16336 +22
===========================================
+ Hits 12879 12880 +1
- Misses 3435 3456 +21
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Added fallback logic to set `value_type` as "url" when not specified for TimeSeries. This ensures proper handling of cases where the `valueType` is undefined, improving consistency in processing.
Updated `MultiChannel` and `TimeSeriesVisualizer` components to correctly respect the `fixedscale` property when defined at various levels. Added logic to handle inheritance of the `fixedscale` value to ensure proper scaling behavior within nested structures.
Corrected the equality check for `value_type` from `== None` to `is None`. This change ensures adherence to Python best practices and improves code reliability.
First attempt into docs
…nto develop # Conflicts: # web/libs/core/src/lib/utils/feature-flags/flags.ts
web/libs/editor/src/tags/object/TimeSeries/ChannelLegend.module.scss
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
These colours won't be dark mode compatible as they are from the primitive colour collections.
We have a dark mode compatible collection accent
of the colours here:
https://labelstud.io/storybook/?path=/story/design-tokens--tokens-catalog
We should likely aim for base
of each color type, with sand using bold
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just the colours need to be updated to be dark mode compatible which I left suggestions for each, rest looks awesome!
Fix colors Co-authored-by: bmartel <[email protected]>
/fmt |
…l-studio into fb-BROS-44/multichannel
Add the ability to group channels into one plot.
Before
After
Summary of the Pull Request
This PR introduces key updates designed to enhance the functionality of the TimeSeries component through new features.
Feature Flags:
Added FF_MULTICHANNEL_TS feature flag to enable multi-channel visualization for TimeSeries.
New Features:
MultiChannel
orTimeseries
Feature Enhancements:
Rollout Strategy:
The critical changes are gated under the FF_MULTICHANNEL_TS feature flag.