Skip to content

Remove locks from KeyBundle #108

Open
@jschlyter

Description

@jschlyter
Collaborator

In production systems it turns out readerwriter locks sometimes ends up trying to release locks multiple times. It would help a lot if we could make KeyBundle thread safe without the use of locks.

Activity

self-assigned this
on Feb 25, 2022
rohe

rohe commented on Feb 25, 2022

@rohe
Contributor

Agree! I don't have any proposal right now. If I come up with something I'll let you know.

jschlyter

jschlyter commented on Feb 25, 2022

@jschlyter
CollaboratorAuthor

Reading the code for KeyBundle there seems to be some wrong assumptions, e.g. that arrays are copied by value and not reference.

rohe

rohe commented on Feb 25, 2022

@rohe
Contributor

Agree, should be fixed. You or me ?

jschlyter

jschlyter commented on Feb 25, 2022

@jschlyter
CollaboratorAuthor

I've started in #110. To remove the locks, we could begin with the read locks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

Type

No type

Projects

No projects

Milestone

No milestone

Relationships

None yet

    Development

    No branches or pull requests

      Participants

      @jschlyter@rohe

      Issue actions

        Remove locks from KeyBundle · Issue #108 · IdentityPython/JWTConnect-Python-CryptoJWT