Skip to content

Fix log file env in ray worker #3624

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 13, 2025
Merged

Conversation

RunningLeon
Copy link
Collaborator

@RunningLeon RunningLeon commented Jun 9, 2025

Motivation

Fix not passing env LMDEPLOY_LOG_FILE to ray worker.

Ray runtime env setting reference: https://docs.ray.io/en/latest/ray-core/handling-dependencies.html#environment-dependencies

Modification

Please briefly describe what modification is made in this PR.

BC-breaking (Optional)

Does the modification introduce changes that break the backward-compatibility of the downstream repositories?
If so, please describe how it breaks the compatibility and how the downstream projects should modify their code to keep compatibility with this PR.

Use cases (Optional)

If this PR introduces a new feature, it is better to list some use cases here, and update the documentation.

Checklist

  1. Pre-commit or other linting tools are used to fix the potential lint issues.
  2. The modification is covered by complete unit tests. If not, please add more unit tests to ensure the correctness.
  3. If the modification has a dependency on downstream projects of a newer version, this PR should be tested with all supported versions of downstream projects.
  4. The documentation has been modified accordingly, like docstring or example tutorials.

@RunningLeon RunningLeon requested a review from lvhan028 June 9, 2025 07:07
@lvhan028 lvhan028 requested a review from grimoire June 13, 2025 07:00
lvhan028 pushed a commit that referenced this pull request Jun 13, 2025
@lvhan028 lvhan028 merged commit 0864ba6 into InternLM:main Jun 13, 2025
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants