Public Network State merge #5274
Draft
+1,693
−605
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Instead of writing `PublicPeerSelectionState` on each outbound governor loop iteration, provide a request-response API through a `StrictTMVar` which is monitored by the outbound governor. Note that `PublicPeerSelectionState` is a lazy record written through `StrictTMVar` via a lazy `Maybe` like type (and thus it is not evaluated to WHNF when written to the shared variable). It is up to the API user to evaluate what it needs.
It includes data from connection-manager and outbound/inbound governors.
…aring.Codec module The `Ouroboros.Network.RemoteAddress.Codec` seems like a better place for it, since its not only `peer-sharing` related.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Main merge test