[IP-841]: Copy Quote UI feedback

[Verony-makesIT]

Description

The ajax form doesn't post because there is no response from the backend.
The problem comes when fetching the 'custom_fields' data.
As far as I understand it, the ( existing?) data is retrieved from the custom_fields db and put into an array.
If there is no data in the db the array cannot be populated and as a result of this there is no "response".
Therefore, in modal_copy_quote, the code

if (response.success === 1) {
    window.location = "<?php echo site_url('invoices/view'); ?>/" + response.invoice_id;
}

is not executed in order to close the modal window and to display the copied quote view page.
To solve the problem I extracted the snippet (copied the custom_fields code) from mdl_invoice.php and modified it in mdl_quotes.php.

Related Issue

#841 Copy quote (modal) UI feedback

Motivation and Context

#841 See description

• Bugfix: Selected quote date is saved
  See commits
• Bugfix: Other client can be selected from list
  See commits

Screenshots (if appropriate):

Pull Request Checklist

• My code follows the code formatting guidelines.
• I have an issue ID for this pull request.
• I selected the corresponding branch.
• I have rebased my changes on top of the corresponding branch.

Issue Type (Please check one or more)

• Bugfix
• Improvement of an existing Feature
• New Feature

[Verony-makesIT]

@nielsdrost7:
I have read your comments in slack (comment 1 and comment 2) and replied to them in slack (my answer) as well.
I regret that my proposal (PR) to fix these bugs is now temporarily (?) put "on hold" while I think there is a misunderstanding.
The additional bug (see screenshots) occurs in "Copy Invoice" and not in "Copy Quote".
Commit:

Bug (in Copy Invoice):

@nielsdrost7, @naui95, @clockwiseq, ...?
After reading my comments in slack, can any of the moderators, reviewers clarify to me what else is expected of me?
The most important thing, in my opinion, is that issues in IP be fixed asap.....

[naui95]

Dear @Verony-makesIT thank you for the further explanations. Your PR AFAIK is not on hold but just pending review. I personally still did not have time to check out the changes and to test them (and eventually get back to you with any question I might have). Please consider that an update has already been planned and at the moment this fix is not included in the upcoming update (see https://github.com/InvoicePlane/InvoicePlane/releases and https://github.com/InvoicePlane/InvoicePlane/milestone/10), which means the review and integration of this PR is - in my opinion - not top priority at the moment. We really appreciate your contributions to the IP community and code base and fully agree with the idea that issues must be fixed.

[nielsdrost7]

Same here: I haven't had time to take a look at your PR, @Verony-makesIT
We appreciate your PR's, but you're going to have to wait some more until we have time to take a look at it

[naui95]

@Verony-makesIT can the PR be considered finished or is it still a draft?

[naui95]

closes #841
closes #1019

[Verony-makesIT]

@naui95,
I just did some testing to see if Copy Quote and Copy Invoice were still working correctly and everything seems to be fine for me.
So the PR can be considered finished.

[naui95]

Hey, thank you for the PR. The PR works well 👍 there are some changes to be made in my opinion; I've commented the relevant code lines. Some changes go too far and I would revert them to the original solution.

The PR solves more bugs than the original issue, in particular solves:

• feedback on quote copied (needs changes before merging)
• fixes a bug affecting the ability to select an other client when creating a copy of an invoice
• fixes a bug affecting the date chosen by the modal post when copying a quote

For future reference: it would be better to make different issues and PRs for different bugs.

[nielsdrost7]

@Verony-makesIT thank you for your PR.
A couple of general things:

• Normally, don't solve multiple bugs in 1 PR
• Please don't change 'other' things in the same PR as you're solving bugs in.

Right now you're solving bug #932 and feature #1019, right? OK, solved, move on.
Then you're solving something about a client not being set, correct? OK, great, the issue was "copy quote feedback", fine, let's move on.

But wait a minute ... you're also changing a date to today's date after copying the quote?
And that was something that needed to be discussed?

So now we need to iron out 1 thing that had absolutely nothing to do with solving some bugs? ai, ai.

[nielsdrost7]

One last thing, before u have to go over the source itself (indenting problems in the translation file?)

Could you take a look at naui's and my remarks regarding #932 (comment) ?
As soon as some piece of code 'disappears' some bugs may pop up.
I think naui suggested some extra code was needed, focus on that please.
My remark regarding saving the empty array can easily be resolved, but do that after you've solve the other things

[nielsdrost7]

@Verony-makesIT I'll try to make a checklist for you to go over, before we can check the PR one more time and then merge the solution for the Copy Quote UI Feedback:

• https://github.com/InvoicePlane/InvoicePlane/pull/932/files#r1518791594 : very important. When someone makes a comment and then requests changes we cannot merge until those changes have been resolved. I think that single change you made has to be reverted. I can't see which commit it is, but it should be something like git revert abc13455bca
• Fix all the other remarks from naui95, for example here: https://github.com/InvoicePlane/InvoicePlane/pull/932/files#r1527185594 I believe that a slice of the original code was accidentally left out (see: #932 (comment))
• Last but not least: https://github.com/InvoicePlane/InvoicePlane/pull/932/files/7e34967e66f5b62ee34700e34a3a8921271fe3b8#r1528110936 : Remove an "Enter" in a file, since we're changing that file anyway because of your PR, we can remove that "Enter"

Let me know once you're done with these changes, then we can make our final checks.

[naui95]

Fixed copying as proposed and solved conflicts. Ready to go.