Skip to content

[MOB-11561] Android: adds enableEmbeddedMessaging flag to config #647

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Jun 9, 2025
Merged

[MOB-11561] Android: adds enableEmbeddedMessaging flag to config #647

merged 4 commits into from
Jun 9, 2025

Conversation

evantk91
Copy link
Contributor

@evantk91 evantk91 commented Jun 4, 2025 •
edited by jira bot
Loading

🔹 JIRA Ticket(s) if any

✏️ Description

This pull request adds enableEmbeddedMessaging flag to config.

@evantk91 evantk91 changed the base branch from master to evan/MOB-8751 June 4, 2025 23:15
@github-actions GitHub Actions
Copy link

github-actions bot commented Jun 4, 2025 •
edited
Loading

Lines Statements Branches Functions
Coverage: 38%
 38.13% (180/472) 11.29% (20/177) 32.05% (50/156)

@codeclimate CodeClimate
Copy link

codeclimate bot commented Jun 4, 2025 •
edited
Loading

All good ✅
This is from Qlty Cloud, the successor to Code Climate Quality. Learn more.

@evantk91 evantk91 marked this pull request as draft June 4, 2025 23:17
Base automatically changed from evan/MOB-8751 to evan/feature/embedded June 6, 2025 20:51
@evantk91 evantk91 requested a review from lposen June 6, 2025 20:59
@evantk91 evantk91 marked this pull request as ready for review June 6, 2025 20:59
lposen
lposen reviewed Jun 9, 2025
View reviewed changes
Copy link
Contributor

@lposen lposen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is iOS addressed in this? I don't see it, but could be missing something.

@evantk91
Copy link
Contributor Author

evantk91 commented Jun 9, 2025

Is iOS addressed in this? I don't see it, but could be missing something.

iOS is not addressed. I will be doing that on a separate PR. I will update the title to reflect this.

@evantk91 evantk91 changed the title [MOB-11561] adds enableEmbeddedMessaging flag to config [MOB-11561] Android: adds enableEmbeddedMessaging flag to config Jun 9, 2025
@evantk91 evantk91 merged commit 904676b into evan/feature/embedded Jun 9, 2025
5 checks passed
@evantk91 evantk91 deleted the evan/MOB-11561-enableEmbeddedMessaging-flag branch June 9, 2025 21:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lposen lposen lposen approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@evantk91 @lposen