Feature/removeemojies #23
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Changes Unknown when pulling f2cc45b on feature/removeemojies into ** on master**. |
aichbauer
reviewed
Apr 18, 2017
.sgcrc_default
Outdated
| @@ -1,4 +1,5 @@ | |||
| { | |||
| "emojies": true, | |||
There was a problem hiding this comment.
readme says emojies is default false, we should change the readme to true, or here to false.
| @@ -5,7 +5,8 @@ const choices = (configuration) => { | |||
| const choicesList = []; | |||
|
|
|||
| configuration.types.forEach((type) => { | |||
| const emoji = `${type.emoji} ` || ''; | |||
| const isEmojies = configuration.emojies === undefined ? true : configuration.emojies; | |||
There was a problem hiding this comment.
We do not have a emojies: false in the sgc_defalut, so this means the documentation in the readme is wrong... because if emojies is undefined, emojies = true we need to cheange this to false or we have to change the readme to default true
README.md
Outdated
|
|
||
| **Type:** `boolean` | ||
|
|
||
| **Default:** `false` |
There was a problem hiding this comment.
see lib/promptConfig.js
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In the
.sgcrcthe optionemojiescan be used to disable emojies in the commit. Forv2.0.0we can disable emojies by default.