Fix: trim trailing spaces (closes #39) #41
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JPeer264
requested changes
Sep 8, 2017
lib/rules/availableRules.js
Outdated
| @@ -10,25 +10,25 @@ const rules = { | |||
| }, | |||
| }), | |||
| maxChar: (input, config) => ({ | |||
| message: () => `The commit message is not allowed to be longer as ${config.rules['max-char']} character, but is ${input.length} character long. Consider writing a body.`, | |||
| message: () => `The commit message is not allowed to be longer as ${config.rules['max-char']} character, but is ${input.trim().length} character long. Consider writing a body.`, | |||
There was a problem hiding this comment.
Would be better if we trim them here: https://github.com/JPeer264/node-semantic-git-commit-cli/blob/master/lib/questions.js#L62
Then it would apply to every rule automatically. So we do not have to touch this file.
Repository owner
deleted a comment from
coveralls
Sep 8, 2017
JPeer264
approved these changes
Sep 12, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.