Skip to content

chore: update winget config file location & extension#6202

Merged
JanDeDobbeleer merged 1 commit intoJanDeDobbeleer:nextfrom
mdanish-kh:config-convention
Mar 1, 2025
Merged

chore: update winget config file location & extension#6202
JanDeDobbeleer merged 1 commit intoJanDeDobbeleer:nextfrom
mdanish-kh:config-convention

Conversation

@mdanish-kh
Copy link
Copy Markdown
Contributor

Prerequisites

  • I have read and understood the contributing guide.
  • The commit message follows the conventional commits guidelines.
  • Tests for the changes have been added (for bug fixes / features).
  • Docs have been added/updated (for bug fixes / features).

Description

Update the WinGet configuration file location and extension in accordance with the latest file naming convention

@denelon
Copy link
Copy Markdown
Contributor

denelon commented Feb 27, 2025

Thanks @mdanish-kh I think @vedantmgoyal9 had attempted this before we had updated our guidance, so I wanted to let him know about this PR as well.

@denelon
Copy link
Copy Markdown
Contributor

denelon commented Feb 27, 2025

There are also documentation changes that should be made over at: https://ohmyposh.dev/docs/contributing/started

@denelon
Copy link
Copy Markdown
Contributor

denelon commented Feb 27, 2025

image

@mdanish-kh
Copy link
Copy Markdown
Contributor Author

The docs have been updated as part of the PR

@JanDeDobbeleer JanDeDobbeleer changed the base branch from main to next March 1, 2025 16:13
@JanDeDobbeleer JanDeDobbeleer merged commit 2d1b436 into JanDeDobbeleer:next Mar 1, 2025
12 checks passed
@JanDeDobbeleer
Copy link
Copy Markdown
Owner

@all-contributors please add @mdanish-kh for doc

This is pure magic 🪄! @holopin-bot @mdanish-kh wizard

@holopin-bot
Copy link
Copy Markdown

holopin-bot bot commented Mar 1, 2025

Congratulations @mdanish-kh, the maintainer of this repository has issued you a badge! Here it is: https://holopin.io/claim/cm7qekjn2130060claws8trns3

This badge can only be claimed by you, so make sure that your GitHub account is linked to your Holopin account. You can manage those preferences here: https://holopin.io/account.
Or if you're new to Holopin, you can simply sign up with GitHub, which will do the trick!

@allcontributors
Copy link
Copy Markdown
Contributor

@JanDeDobbeleer

I've put up a pull request to add @mdanish-kh! 🎉

@mdanish-kh mdanish-kh deleted the config-convention branch March 1, 2025 16:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants