Skip to content

Rename to react-juce #202

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Jan 10, 2021
Merged

Rename to react-juce #202

merged 5 commits into from
Jan 10, 2021

Conversation

nick-thompson
Copy link
Collaborator

(#34) w00t!

This is a huge PR, but it breaks down quite simply. The first commit is the result of simply

$ for file in blueprint_*; do mv "$file" "${file#blueprint_}"; done

to rename all files in blueprint/core to remove the blueprint_ prefix.

The second commit renames the directory itself from blueprint/ to react_juce/, updates all of the includes within the module (which conveniently addresses #166), and bumps the GainPlugin example to build with it.

My goal was for this separation of commits to reduce the pain of any merge conflicts, aiming to convince git that 98% of the work here is just renaming files. I hope it works...

Lastly, I believe this will be largely non-breaking for end users except that now they will need to:

  1. Update their submodules as yoga now resides in react_juce/yoga
  2. Add the react_juce juce module instead of the blueprint module.

Hopefully not too painful.

Anybody interested, please pull this branch and try it out! This touches so much of the project that I would love as many eyes on this as possible before merging.

Finally, in a subsequent PR, I'll address what I believe is the last part of this transition, renaming the blueprint namespace to reactjuce, updating the docs, and tackling any stragglers.

🎉

@JoshMarler
Copy link
Owner

Woooaah you tackled the beast. Will take a proper look this evening.

@nick-thompson
Copy link
Collaborator Author

Hey @JoshMarler, just updated per our conversation in the chatroom about the include directives. I've updated the includes along the model "include what you need," hopefully that helps with IDE file resolution.

One note, because this renames the blueprint/ directory to react_juce/, when you pull you'll have to update your submodules (for yoga).

Mind taking a local pass wiith this one to verify I haven't broken things?

@JoshMarler
Copy link
Owner

@nick-thompson , will pull this and run through today for a proper review.

@JoshMarler
Copy link
Owner

@nick-thompson ,

Assuming this is just file renames and path updates it's all looking good to me. Have pulled down and built on linux. One possible missed rename in cpp sources: blueprint_EcmascriptEngineTests.h

Also, did we want to rename the BlueprintBackend.ts and BlueprintRenderer.ts files as part of this change?

Otherwise looks solid.

@nick-thompson
Copy link
Collaborator Author

@JoshMarler great, thanks for checking that out, and yea good catch on the test file, will update

I'll come back through for lingering changes like BlueprintBackend.ts in a subsequent PR; focusing mostly on getting things to compile again here

@JoshMarler
Copy link
Owner

Awesome no worries. Away from desk possibly till morning now but shout if you want me to test on Mac/Win. Think CI should catch any issues now?

@nick-thompson
Copy link
Collaborator Author

CI built fine for mac/linux/win, so I feel confident. I think I'll go ahead and merge, get this party started!

@nick-thompson
Copy link
Collaborator Author

🚀

@nick-thompson nick-thompson deleted the file-rename branch January 10, 2021 18:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants