-
-
Notifications
You must be signed in to change notification settings - Fork 81
Rename to react-juce #202
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rename to react-juce #202
Conversation
Woooaah you tackled the beast. Will take a proper look this evening. |
8dcc8b8
to
00a7a90
Compare
Hey @JoshMarler, just updated per our conversation in the chatroom about the include directives. I've updated the includes along the model "include what you need," hopefully that helps with IDE file resolution. One note, because this renames the Mind taking a local pass wiith this one to verify I haven't broken things? |
@nick-thompson , will pull this and run through today for a proper review. |
Assuming this is just file renames and path updates it's all looking good to me. Have pulled down and built on linux. One possible missed rename in cpp sources: Also, did we want to rename the Otherwise looks solid. |
@JoshMarler great, thanks for checking that out, and yea good catch on the test file, will update I'll come back through for lingering changes like |
Awesome no worries. Away from desk possibly till morning now but shout if you want me to test on Mac/Win. Think CI should catch any issues now? |
CI built fine for mac/linux/win, so I feel confident. I think I'll go ahead and merge, get this party started! |
🚀 |
(#34) w00t!
This is a huge PR, but it breaks down quite simply. The first commit is the result of simply
to rename all files in
blueprint/core
to remove theblueprint_
prefix.The second commit renames the directory itself from
blueprint/
toreact_juce/
, updates all of the includes within the module (which conveniently addresses #166), and bumps the GainPlugin example to build with it.My goal was for this separation of commits to reduce the pain of any merge conflicts, aiming to convince git that 98% of the work here is just renaming files. I hope it works...
Lastly, I believe this will be largely non-breaking for end users except that now they will need to:
react_juce
juce module instead of theblueprint
module.Hopefully not too painful.
Anybody interested, please pull this branch and try it out! This touches so much of the project that I would love as many eyes on this as possible before merging.
Finally, in a subsequent PR, I'll address what I believe is the last part of this transition, renaming the
blueprint
namespace toreactjuce
, updating the docs, and tackling any stragglers.🎉