Skip to content

(#34) Rename top-level namespace to reactjuce:: #216

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Jan 23, 2021

Conversation

nick-thompson
Copy link
Collaborator

w00t!

After this, most of what's left is updating references to "Blueprint" in the documentation and internal names for coordinating js<>C++ access (e.g. BlueprintBackend)

@nick-thompson
Copy link
Collaborator Author

Just tacked on a second commit to cover what I think is the rest of the real renaming effort. Probably best to look at this commit by commit now.

After this, all that's left is really:

  • Updating the documentation to replace instances of "Blueprint"
  • Addressing the TestRunner code

Before merging this I'll bump react-juce to 0.2.10 on npm and update the package jsons

@nick-thompson nick-thompson force-pushed the feature/rename-namespace branch from e820c25 to d2b3c99 Compare January 23, 2021 17:23
@JoshMarler
Copy link
Owner

@nick-thompson, Nice! Looking solid. Pulled down on linux machine and all looking good.

Ran a grep under react-juce/core directory and still a few "blueprint" references. Are we leaving for the moment? Things like:

#ifdef BLUEPRINT_H_INCLUDED

funcId(juce::String("blueprintCallback")

Also index.js in GainPlugin example.

I'm not sure if these are outside the planned scope of this PR?

@nick-thompson nick-thompson force-pushed the feature/rename-namespace branch from d2b3c99 to 4e3f8f2 Compare January 23, 2021 22:06
@nick-thompson
Copy link
Collaborator Author

Ok, covered another few and bumped 0.2.10 on npm.

#ifdef BLUEPRINT_H_INCLUDED I will come back for in a later PR while also addressing the test runner.

@nick-thompson nick-thompson merged commit a0d864f into master Jan 23, 2021
@nick-thompson nick-thompson deleted the feature/rename-namespace branch January 23, 2021 23:04
@nick-thompson nick-thompson mentioned this pull request Jan 23, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants