-
Notifications
You must be signed in to change notification settings - Fork 103
Rewrite of edit_distance
with edge costs. fix #111
#137
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #137 +/- ##
==========================================
- Coverage 97.26% 97.17% -0.10%
==========================================
Files 114 114
Lines 6579 6649 +70
==========================================
+ Hits 6399 6461 +62
- Misses 180 188 +8 |
The tests fail because they now include doctests, it shouldn't be too hard to adapt? |
gdalle
approved these changes
Jun 28, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #111
I changed the default costs, as otherwise, the default algorithm as absolutely no meaning. I kept in the file the
MinkowskiCost
andBoundedMinkowskiCost
to avoid breakage because they are exported, but we should deprecate these methods, they are useless IMO.I adapted the code to fix the support of directed graphs and self loops.
I kept the same type of implementation as before with a BFS , but I don't think that's a great idea, this allocates tremendously, even for rather small graphs. It should be good to rewrite this as a backtracking algorithm with some more efficient pruning, or using constraint programming or linear programming. IMO, we should at some point move it to the future GraphOptim, I don't think we have many exponential complexity functions in the code base, and this function merit a slightly more involved implementation.